ash/autoclick/autoclick_controller.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/autoclick/autoclick_controller.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/autoclick/autoclick_controller.cc

diff --git a/ash/autoclick/autoclick_controller.cc b/ash/autoclick/autoclick_controller.cc

index 39d1b020d6db22ef54fe7fcee064579028687d40..21b8e26ab5e180922ac37fe365deeb6d57040ced 100644

--- a/ash/autoclick/autoclick_controller.cc

+++ b/ash/autoclick/autoclick_controller.cc

@@ -153,12 +153,9 @@ void AutoclickControllerImpl::OnMouseEvent(ui::MouseEvent* event) {

}

void AutoclickControllerImpl::OnKeyEvent(ui::KeyEvent* event) {

- int modifier_mask =

- ui::EF_SHIFT_DOWN |

- ui::EF_CONTROL_DOWN |

- ui::EF_ALT_DOWN |

- ui::EF_COMMAND_DOWN |

- ui::EF_EXTENDED;

+ int modifier_mask = ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN |

+ ui::EF_ALT_DOWN | ui::EF_COMMAND_DOWN |

+ ui::EF_IS_EXTENDED_KEY;

int new_modifiers = event->flags() & modifier_mask;

mouse_event_flags_ = (mouse_event_flags_ & ~modifier_mask) | new_modifiers;