Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5911)

Unified Diff: chrome/browser/media/android/remote/remote_media_player_manager.cc

Issue 1559153002: RemoteMediaPlayerManager: delete players on correct thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/android/remote/remote_media_player_manager.cc
diff --git a/chrome/browser/media/android/remote/remote_media_player_manager.cc b/chrome/browser/media/android/remote/remote_media_player_manager.cc
index 301abde27b4fbbb73adbbb1482b93ea9b833c9a8..6b7efa91e8acfc45d9e5df1a6005d7301ca8babf 100644
--- a/chrome/browser/media/android/remote/remote_media_player_manager.cc
+++ b/chrome/browser/media/android/remote/remote_media_player_manager.cc
@@ -20,7 +20,12 @@ RemoteMediaPlayerManager::RemoteMediaPlayerManager(
weak_ptr_factory_(this) {
}
-RemoteMediaPlayerManager::~RemoteMediaPlayerManager() {}
+RemoteMediaPlayerManager::~RemoteMediaPlayerManager() {
+ for (MediaPlayerAndroid* player : alternative_players_)
+ player->DeleteOnCorrectThread();
+
+ alternative_players_.weak_clear();
+}
void RemoteMediaPlayerManager::OnStart(int player_id) {
RemoteMediaPlayerBridge* remote_player = GetRemotePlayer(player_id);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698