Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/media/android/remote/remote_media_player_manager.cc

Issue 1559153002: RemoteMediaPlayerManager: delete players on correct thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/android/remote/remote_media_player_manager.h" 5 #include "chrome/browser/media/android/remote/remote_media_player_manager.h"
6 6
7 #include "chrome/browser/android/tab_android.h" 7 #include "chrome/browser/android/tab_android.h"
8 #include "chrome/common/chrome_content_client.h" 8 #include "chrome/common/chrome_content_client.h"
9 #include "content/common/media/media_player_messages_android.h" 9 #include "content/common/media/media_player_messages_android.h"
10 #include "third_party/skia/include/core/SkBitmap.h" 10 #include "third_party/skia/include/core/SkBitmap.h"
11 #include "ui/gfx/android/java_bitmap.h" 11 #include "ui/gfx/android/java_bitmap.h"
12 12
13 using media::MediaPlayerAndroid; 13 using media::MediaPlayerAndroid;
14 14
15 namespace remote_media { 15 namespace remote_media {
16 16
17 RemoteMediaPlayerManager::RemoteMediaPlayerManager( 17 RemoteMediaPlayerManager::RemoteMediaPlayerManager(
18 content::RenderFrameHost* render_frame_host) 18 content::RenderFrameHost* render_frame_host)
19 : BrowserMediaPlayerManager(render_frame_host), 19 : BrowserMediaPlayerManager(render_frame_host),
20 weak_ptr_factory_(this) { 20 weak_ptr_factory_(this) {
21 } 21 }
22 22
23 RemoteMediaPlayerManager::~RemoteMediaPlayerManager() {} 23 RemoteMediaPlayerManager::~RemoteMediaPlayerManager() {
24 for (MediaPlayerAndroid* player : alternative_players_)
25 player->DeleteOnCorrectThread();
26
27 alternative_players_.weak_clear();
28 }
24 29
25 void RemoteMediaPlayerManager::OnStart(int player_id) { 30 void RemoteMediaPlayerManager::OnStart(int player_id) {
26 RemoteMediaPlayerBridge* remote_player = GetRemotePlayer(player_id); 31 RemoteMediaPlayerBridge* remote_player = GetRemotePlayer(player_id);
27 if (remote_player && IsPlayingRemotely(player_id)) 32 if (remote_player && IsPlayingRemotely(player_id))
28 remote_player->Start(); 33 remote_player->Start();
29 34
30 BrowserMediaPlayerManager::OnStart(player_id); 35 BrowserMediaPlayerManager::OnStart(player_id);
31 } 36 }
32 37
33 void RemoteMediaPlayerManager::OnInitialize( 38 void RemoteMediaPlayerManager::OnInitialize(
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
257 BrowserMediaPlayerManager::OnMediaMetadataChanged(player_id, duration, 262 BrowserMediaPlayerManager::OnMediaMetadataChanged(player_id, duration,
258 width, height, success); 263 width, height, success);
259 } 264 }
260 } 265 }
261 266
262 bool RemoteMediaPlayerManager::IsPlayingRemotely(int player_id) { 267 bool RemoteMediaPlayerManager::IsPlayingRemotely(int player_id) {
263 return players_playing_remotely_.count(player_id) != 0; 268 return players_playing_remotely_.count(player_id) != 0;
264 } 269 }
265 270
266 } // namespace remote_media 271 } // namespace remote_media
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698