Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: chrome/browser/bookmarks/DEPS

Issue 155913004: Eliminate Bookmarks dependence to bookmark_undo_utils.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All grouped action to notify BookmarkModelObservers Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | chrome/browser/bookmarks/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/bookmarks/DEPS
diff --git a/chrome/browser/bookmarks/DEPS b/chrome/browser/bookmarks/DEPS
index 7191e8f9ec0e5e647084808a01fabaa21798c1e5..2dfbe04e567cbdeb0184986ddee965ab1580438f 100644
--- a/chrome/browser/bookmarks/DEPS
+++ b/chrome/browser/bookmarks/DEPS
@@ -1,35 +1,34 @@
-include_rules = [
- # Bookmarks is being made into a component (it will end up at
- # //components/bookmarks and not depend on //chrome), so we have these basic
- # rules followed by temporary exceptions. Please don't add to the list of
- # exceptions!
- "-chrome/browser",
- "+chrome/browser/bookmarks",
- "+chrome/browser/favicon",
- "+chrome/browser/chrome_notification_types.h",
- "+chrome/browser/undo/bookmark_undo_service.h",
- "+chrome/browser/undo/bookmark_undo_service_factory.h",
- "+chrome/browser/undo/bookmark_undo_utils.h",
-
- # TODO(tfarina): Bring this list to zero. crbug.com/144783
- # Do not add to the list of temporarily-allowed dependencies below,
- # and please do not introduce more #includes of these files.
- "!chrome/browser/history/history_service.h",
- "!chrome/browser/history/history_service_factory.h",
- "!chrome/browser/history/query_parser.h",
- "!chrome/browser/history/url_database.h",
- "!chrome/browser/profiles/incognito_helpers.h",
- "!chrome/browser/profiles/profile.h",
- "!chrome/browser/profiles/startup_task_runner_service.h",
- "!chrome/browser/profiles/startup_task_runner_service_factory.h",
- # Do not add to the list of temporarily-allowed dependencies above,
- # and please do not introduce more #includes of these files.
-]
-
-specific_include_rules = {
- # For unit tests, it's fine to include utility process code.
- '.*test\.cc': [
- "!chrome/test/base/testing_profile.h",
- "+chrome/utility/importer/bookmark_html_reader.h",
- ],
-}
+include_rules = [
+ # Bookmarks is being made into a component (it will end up at
+ # //components/bookmarks and not depend on //chrome), so we have these basic
+ # rules followed by temporary exceptions. Please don't add to the list of
+ # exceptions!
+ "-chrome/browser",
+ "+chrome/browser/bookmarks",
+ "+chrome/browser/favicon",
+ "+chrome/browser/chrome_notification_types.h",
+ "+chrome/browser/undo/bookmark_undo_service.h",
+ "+chrome/browser/undo/bookmark_undo_service_factory.h",
+
+ # TODO(tfarina): Bring this list to zero. crbug.com/144783
+ # Do not add to the list of temporarily-allowed dependencies below,
+ # and please do not introduce more #includes of these files.
+ "!chrome/browser/history/history_service.h",
+ "!chrome/browser/history/history_service_factory.h",
+ "!chrome/browser/history/query_parser.h",
+ "!chrome/browser/history/url_database.h",
+ "!chrome/browser/profiles/incognito_helpers.h",
+ "!chrome/browser/profiles/profile.h",
+ "!chrome/browser/profiles/startup_task_runner_service.h",
+ "!chrome/browser/profiles/startup_task_runner_service_factory.h",
+ # Do not add to the list of temporarily-allowed dependencies above,
+ # and please do not introduce more #includes of these files.
+]
+
+specific_include_rules = {
+ # For unit tests, it's fine to include utility process code.
+ '.*test\.cc': [
+ "!chrome/test/base/testing_profile.h",
+ "+chrome/utility/importer/bookmark_html_reader.h",
+ ],
+}
« no previous file with comments | « no previous file | chrome/browser/bookmarks/bookmark_model.h » ('j') | chrome/browser/bookmarks/bookmark_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698