chrome/browser/bookmarks/bookmark_model.h - Issue 155913004: Eliminate Bookmarks dependence to bookmark_undo_utils.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/bookmark_model.h

Issue 155913004: Eliminate Bookmarks dependence to bookmark_undo_utils.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: All grouped action to notify BookmarkModelObservers Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/bookmarks/bookmark_model.h

diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h

index 9bb35269fb49ff0cab56ae9ab043d0c04ab580ca..2c6edd0737773debf08d458c54b60dd082f4ced0 100644

--- a/chrome/browser/bookmarks/bookmark_model.h

+++ b/chrome/browser/bookmarks/bookmark_model.h

@@ -292,6 +292,11 @@ class BookmarkModel : public content::NotificationObserver,

void BeginExtensiveChanges();

void EndExtensiveChanges();

+ // Notifies the observers that a set of changes initiated by a single user

+ // action is about to happen and has completed.

+ void BeginGroupedChanges();

sky 2014/02/06 17:48:27 Can you make these private and the only way to use

Tom Cassiotis 2014/02/21 17:51:45 Done.

+ void EndGroupedChanges();

// Returns true if this bookmark model is currently in a mode where extensive

// changes might happen, such as for import and sync. This is helpful for

// observers that are created after the mode has started, and want to check

« no previous file with comments | « chrome/browser/bookmarks/DEPS ('k') | chrome/browser/bookmarks/bookmark_model.cc » ('j') | chrome/browser/bookmarks/bookmark_model_observer.h » ('J')