Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: remoting/protocol/video_renderer.h

Issue 1559043004: Add GetFrameConsumer() in VideoRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_video_renderer
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/video_renderer.h
diff --git a/remoting/protocol/video_renderer.h b/remoting/protocol/video_renderer.h
index 4d2c05f7c5f5de024cde73c892fe6cca2047b3d7..da37ffac50a960b1b7f0e355135d627f791f6cef 100644
--- a/remoting/protocol/video_renderer.h
+++ b/remoting/protocol/video_renderer.h
@@ -8,11 +8,17 @@
namespace remoting {
namespace protocol {
+class FrameConsumer;
class SessionConfig;
class VideoStub;
// VideoRenderer is responsible for decoding and displaying incoming video
-// stream.
+// stream. This interface is used by ConnectionToHost implementations to
+// render the video frames to receive. Depending on configuration
Jamie 2016/01/04 22:46:28 s/configuration/the SessionConfig/?
Jamie 2016/01/04 22:46:28 s/to receive/received/? (I think--otherwise I don'
Sergey Ulanov 2016/01/05 18:32:56 Done.
Sergey Ulanov 2016/01/05 18:32:56 Just removed "Depending on configuration". IceConn
+// ConnectionToHost implementation may feed encoded frames to the VideoStub or
+// decode them and pass decoded frames to the FrameConsumer.
+//
+// TODO(sergeyu): Reconsider this design.
class VideoRenderer {
public:
virtual ~VideoRenderer() {}
@@ -23,6 +29,9 @@ class VideoRenderer {
// Returns the VideoStub interface of this renderer.
virtual VideoStub* GetVideoStub() = 0;
+
+ // Returns the FrameConsumer interface for this renderer.
+ virtual FrameConsumer* GetFrameConsumer() = 0;
};
} // namespace protocol;

Powered by Google App Engine
This is Rietveld 408576698