remoting/client/plugin/pepper_video_renderer_3d.cc - Issue 1559043004: Add GetFrameConsumer() in VideoRenderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/pepper_video_renderer_3d.cc

Issue 1559043004: Add GetFrameConsumer() in VideoRenderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_video_renderer

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/client/plugin/pepper_video_renderer_3d.cc

diff --git a/remoting/client/plugin/pepper_video_renderer_3d.cc b/remoting/client/plugin/pepper_video_renderer_3d.cc

index 732b77b149fb049bc7b03081030b7764612f5d42..5213395eb5a77d7a46e0f06a81b37201d44f5898 100644

--- a/remoting/client/plugin/pepper_video_renderer_3d.cc

+++ b/remoting/client/plugin/pepper_video_renderer_3d.cc

@@ -178,6 +178,11 @@ protocol::VideoStub* PepperVideoRenderer3D::GetVideoStub() {

return this;

}

+protocol::FrameConsumer* PepperVideoRenderer3D::GetFrameConsumer() {

+ NOTREACHED();

Jamie 2016/01/04 22:46:28 Can you add a comment explaining why this NOTREACH

Sergey Ulanov 2016/01/05 18:32:56 Done.

+ return nullptr;

void PepperVideoRenderer3D::ProcessVideoPacket(scoped_ptr<VideoPacket> packet,

const base::Closure& done) {

base::ScopedClosureRunner done_runner(done);

« no previous file with comments | « remoting/client/plugin/pepper_video_renderer_3d.h ('k') | remoting/client/software_video_renderer.h » ('j') | remoting/protocol/video_renderer.h » ('J')