Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | 1 // Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef REMOTING_CLIENT_VIDEO_RENDERER_H_ | 5 #ifndef REMOTING_CLIENT_VIDEO_RENDERER_H_ |
| 6 #define REMOTING_CLIENT_VIDEO_RENDERER_H_ | 6 #define REMOTING_CLIENT_VIDEO_RENDERER_H_ |
| 7 | 7 |
| 8 namespace remoting { | 8 namespace remoting { |
| 9 namespace protocol { | 9 namespace protocol { |
| 10 | 10 |
| 11 class FrameConsumer; | |
| 11 class SessionConfig; | 12 class SessionConfig; |
| 12 class VideoStub; | 13 class VideoStub; |
| 13 | 14 |
| 14 // VideoRenderer is responsible for decoding and displaying incoming video | 15 // VideoRenderer is responsible for decoding and displaying incoming video |
| 15 // stream. | 16 // stream. This interface is used by ConnectionToHost implementations to |
| 17 // render the video frames to receive. Depending on configuration | |
|
Jamie
2016/01/04 22:46:28
s/configuration/the SessionConfig/?
Jamie
2016/01/04 22:46:28
s/to receive/received/? (I think--otherwise I don'
Sergey Ulanov
2016/01/05 18:32:56
Done.
Sergey Ulanov
2016/01/05 18:32:56
Just removed "Depending on configuration". IceConn
| |
| 18 // ConnectionToHost implementation may feed encoded frames to the VideoStub or | |
| 19 // decode them and pass decoded frames to the FrameConsumer. | |
| 20 // | |
| 21 // TODO(sergeyu): Reconsider this design. | |
| 16 class VideoRenderer { | 22 class VideoRenderer { |
| 17 public: | 23 public: |
| 18 virtual ~VideoRenderer() {} | 24 virtual ~VideoRenderer() {} |
| 19 | 25 |
| 20 // Configures the renderer with the supplied |config|. This must be called | 26 // Configures the renderer with the supplied |config|. This must be called |
| 21 // exactly once before video data is supplied to the renderer. | 27 // exactly once before video data is supplied to the renderer. |
| 22 virtual void OnSessionConfig(const SessionConfig& config) = 0; | 28 virtual void OnSessionConfig(const SessionConfig& config) = 0; |
| 23 | 29 |
| 24 // Returns the VideoStub interface of this renderer. | 30 // Returns the VideoStub interface of this renderer. |
| 25 virtual VideoStub* GetVideoStub() = 0; | 31 virtual VideoStub* GetVideoStub() = 0; |
| 32 | |
| 33 // Returns the FrameConsumer interface for this renderer. | |
| 34 virtual FrameConsumer* GetFrameConsumer() = 0; | |
| 26 }; | 35 }; |
| 27 | 36 |
| 28 } // namespace protocol; | 37 } // namespace protocol; |
| 29 } // namespace remoting | 38 } // namespace remoting |
| 30 | 39 |
| 31 #endif // REMOTING_CLIENT_VIDEO_RENDERER_H_ | 40 #endif // REMOTING_CLIENT_VIDEO_RENDERER_H_ |
| OLD | NEW |