Issue 155903002: Using hasTagName() instead of tagName() while checking textarea type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155903002: Using hasTagName() instead of tagName() while checking textarea type (Closed)

Created:
6 years, 10 months ago by ziran.sun

Modified:
6 years, 10 months ago

Reviewers:
tkent

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Using hasTagName() instead of tagName() while checking textarea type This is a legacy issue that uses tagName() instead of hasTagName() to make Windows port link QualifiedNames properly. Windows doesn't have this problem any more. R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166563

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	Source/core/testing/Internals.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ziran.sun@samsung.com/155903002/1

6 years, 10 months ago (2014-02-05 23:36:44 UTC) #3

Message was sent while issue was closed.

Change committed as 166563

Expand Messages | Collapse Messages