Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: Source/core/testing/Internals.cpp

Issue 155903002: Using hasTagName() instead of tagName() while checking textarea type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index f6136ed6e43769fa59418def7d3b30a348c906fe..361130cadc7fa65b91f0a74260ac1895f62d8c91 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -1000,8 +1000,7 @@ bool Internals::wasLastChangeUserEdit(Element* textField, ExceptionState& except
if (textField->hasTagName(inputTag))
return toHTMLInputElement(textField)->lastChangeWasUserEdit();
- // FIXME: We should be using hasTagName instead but Windows port doesn't link QualifiedNames properly.
- if (textField->tagName() == "TEXTAREA")
+ if (textField->hasTagName(textareaTag))
return toHTMLTextAreaElement(textField)->lastChangeWasUserEdit();
exceptionState.throwDOMException(InvalidNodeTypeError, "The element provided is not a TEXTAREA.");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698