Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1559023002: [tracing] Make memory-infra unregristration DCHECK stricter

Created:
4 years, 11 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 11 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mdm_delete_async
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Make memory-infra unregristration DCHECK stricter This is a follow-up to the discussion started in crrev.com/1430073002 . There is no reason for DCHECK-ing against unsafe unregistrations of memory dump providers only when tracing is enabled. A safe unregistration should always be performed, regardless of the state of tracing. BUG=

Patch Set 1 #

Patch Set 2 : +browsertests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 16 chunks +21 lines, -20 lines 0 comments Download
M components/tracing/child_trace_message_filter_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tracing/memory_tracing_browsertest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (3 generated)
Primiano Tucci (use gerrit)
4 years, 11 months ago (2016-01-04 16:17:25 UTC) #2
Primiano Tucci (use gerrit)
+oysteine for OWNERS I haz no power in //components/tracing and //content/browser/tracing/
4 years, 11 months ago (2016-01-04 16:18:43 UTC) #4
Ruud van Asseldonk
Patchset 2 looks good to me, but it looks like you were right about dumpers ...
4 years, 11 months ago (2016-01-04 18:43:32 UTC) #5
oystein (OOO til 10th of July)
4 years, 11 months ago (2016-01-04 21:45:56 UTC) #7
On 2016/01/04 18:43:32, Ruud van Asseldonk wrote:
> Patchset 2 looks good to me, but it looks like you were right about dumpers
> doing unsafe unregistration after tracing is disabled.

lgtm for //components/tracing and //content/browser/tracing

Powered by Google App Engine
This is Rietveld 408576698