base/trace_event/memory_dump_manager.cc - Issue 1559023002: [tracing] Make memory-infra unregristration DCHECK stricter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.cc

Issue 1559023002: [tracing] Make memory-infra unregristration DCHECK stricter Base URL: https://chromium.googlesource.com/chromium/src.git@mdm_delete_async

Patch Set: +browsertests Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/memory_dump_manager.cc

diff --git a/base/trace_event/memory_dump_manager.cc b/base/trace_event/memory_dump_manager.cc

index a0cc7e124ea098f9d4369db9c3981bcc23083988..1b500e83a0af3039cab25780b08a7bf8ffcff505 100644

--- a/base/trace_event/memory_dump_manager.cc

+++ b/base/trace_event/memory_dump_manager.cc

@@ -249,7 +249,7 @@ void MemoryDumpManager::UnregisterDumpProviderInternal(

// - In the prologue of the ContinueAsyncProcessDump().

DCHECK(!(*mdp_iter)->owned_dump_provider);

(*mdp_iter)->owned_dump_provider = std::move(owned_mdp);

- } else if (subtle::NoBarrier_Load(&memory_tracing_enabled_)) {

+ } else {

// If you hit this DCHECK, your dump provider has a bug.

// Unregistration of a MemoryDumpProvider is safe only if:

// - The MDP has specified a thread affinity (via task_runner()) AND

« no previous file with comments | « no previous file | base/trace_event/memory_dump_manager_unittest.cc » ('j') | no next file with comments »