Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1559003002: [turbofan] Add performance counters for escape analysis (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@improve-node-cache
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add performance counters for escape analysis R=bmeurer@chromium.org BUG=v8:4586 LOG=n Committed: https://crrev.com/89654538e7b5227e5a893064ad31c325d7bede00 Cr-Commit-Position: refs/heads/master@{#33107}

Patch Set 1 #

Patch Set 2 : Remove file logging #

Patch Set 3 : Reupload #

Total comments: 4

Patch Set 4 : Address comments #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/compiler/escape-analysis-reducer.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/escape-analysis-reducer.cc View 1 2 3 4 chunks +7 lines, -1 line 0 comments Download
M src/counters.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen-escape-analysis.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
sigurds
Please let me know if you think these counters are useful
4 years, 11 months ago (2016-01-04 16:25:50 UTC) #1
Benedikt Meurer
LGTM with nits. https://codereview.chromium.org/1559003002/diff/40001/src/compiler/escape-analysis-reducer.cc File src/compiler/escape-analysis-reducer.cc (right): https://codereview.chromium.org/1559003002/diff/40001/src/compiler/escape-analysis-reducer.cc#newcode53 src/compiler/escape-analysis-reducer.cc:53: jsgraph() Nit: Add EscapeAnalysisReducer::isolate() and/or EscapeAnalysisReducer::counters() ...
4 years, 11 months ago (2016-01-05 04:55:58 UTC) #5
sigurds
FYI: Addressed comments. https://codereview.chromium.org/1559003002/diff/40001/src/compiler/escape-analysis-reducer.cc File src/compiler/escape-analysis-reducer.cc (right): https://codereview.chromium.org/1559003002/diff/40001/src/compiler/escape-analysis-reducer.cc#newcode53 src/compiler/escape-analysis-reducer.cc:53: jsgraph() On 2016/01/05 04:55:58, Benedikt Meurer ...
4 years, 11 months ago (2016-01-05 09:22:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559003002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559003002/80001
4 years, 11 months ago (2016-01-05 10:19:21 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-05 10:30:16 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 10:30:29 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/89654538e7b5227e5a893064ad31c325d7bede00
Cr-Commit-Position: refs/heads/master@{#33107}

Powered by Google App Engine
This is Rietveld 408576698