[turbofan] Improve caching in escape analysis.

[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
BUG=v8:4586
LOG=n

Committed: https://crrev.com/3351ed4b78e739c3528ac969560d4357993ed7b9
Cr-Commit-Position: refs/heads/master@{#33106}

[sigurds, 2016-01-04 16:01:48]

PTAL. These are changed that I did during debugging of the deopt support. I've
split them in a separate CL for better readability.

[sigurds, 2016-01-04 17:52:25]

Description was changed from

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
==========

to

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
==========

[sigurds, 2016-01-04 17:52:25]

sigurds@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[sigurds, 2016-01-04 18:10:24]

Description was changed from

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
==========

to

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
BUG=v8:4586
LOG=n
==========

[Benedikt Meurer, 2016-01-05 05:00:01]

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:190: for (size_t i = 0; i < states_.size(); ++i)
{
Nit: for (VirtualState* const state : states_) { ... }

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:200: void
MergeCache::GetVirtualObjects(VirtualState* state) {
This name is weird. This method doesn't really "get" something.

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:202: for (size_t i = 0; i < fields_.size(); ++i)
{
Nit: for (Node* const field : fields_) { ... }

[sigurds, 2016-01-05 09:52:53]

Addressed comments, PTAL again :)

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:190: for (size_t i = 0; i < states_.size(); ++i)
{
On 2016/01/05 05:00:01, Benedikt Meurer wrote:
> Nit: for (VirtualState* const state : states_) { ... }

Done.

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:200: void
MergeCache::GetVirtualObjects(VirtualState* state) {
On 2016/01/05 05:00:01, Benedikt Meurer wrote:
> This name is weird. This method doesn't really "get" something.

Done.

https://codereview.chromium.org/1554073003/diff/100001/src/compiler/escape-an...
src/compiler/escape-analysis.cc:202: for (size_t i = 0; i < fields_.size(); ++i)
{
On 2016/01/05 05:00:01, Benedikt Meurer wrote:
> Nit: for (Node* const field : fields_) { ... }

Done.

[Benedikt Meurer, 2016-01-05 09:59:11]

LGTM.

[sigurds, 2016-01-05 10:00:11]

The CQ bit was checked by sigurds@chromium.org

[commit-bot: I haz the power, 2016-01-05 10:00:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1554073003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1554073003/120001

[commit-bot: I haz the power, 2016-01-05 10:18:03]

Description was changed from

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
BUG=v8:4586
LOG=n
==========

[commit-bot: I haz the power, 2016-01-05 10:18:04]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-05 10:18:56]

Description was changed from

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
BUG=v8:4586
LOG=n
==========

to

==========
[turbofan] Improve caching in escape analysis.

This also fixes a related bug in phi handling.

R=bmeurer@chromium.org
BUG=v8:4586
LOG=n

Committed: https://crrev.com/3351ed4b78e739c3528ac969560d4357993ed7b9
Cr-Commit-Position: refs/heads/master@{#33106}
==========

[commit-bot: I haz the power, 2016-01-05 10:18:56]

Patchset 7 (id:??) landed as
https://crrev.com/3351ed4b78e739c3528ac969560d4357993ed7b9
Cr-Commit-Position: refs/heads/master@{#33106}