Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1558913002: iOS: Fix -msse warnings when building libwebp. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
jzern, sdefresne
CC:
chromium-reviews, skal, urvang, vikasa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

iOS: Fix -msse warnings when building libwebp. iOS still uses Xcode for building, and in Xcode it's possible to switch between device and simulator builds in the IDE -- so target_arch can't be known at gyp time for iOS, it could be either ARM or x86. In pratice, target_arch seems to be some x86 arch, and hence the iOS bots complain `argument unused during compilation: '-msse2'` when doing device builds. Since performance in the simulator isn't critical, just disable the SSE codepath in iOS builds. (GN doesn't have this problem since it doesn't support generating Xcode projects, so don't touch that.) BUG=573779 Committed: https://crrev.com/733d91de9d641917d15ebd0fbb7d153b1474ede3 Cr-Commit-Position: refs/heads/master@{#367309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M third_party/libwebp/libwebp.gyp View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nico
4 years, 11 months ago (2016-01-04 00:52:20 UTC) #2
sdefresne
lgtm
4 years, 11 months ago (2016-01-04 15:28:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558913002/1
4 years, 11 months ago (2016-01-04 15:28:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 15:34:11 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/733d91de9d641917d15ebd0fbb7d153b1474ede3 Cr-Commit-Position: refs/heads/master@{#367309}
4 years, 11 months ago (2016-01-04 15:35:26 UTC) #9
jzern
lgtm
4 years, 11 months ago (2016-01-08 02:17:22 UTC) #10
jzern
4 years, 11 months ago (2016-01-08 02:17:37 UTC) #11
Message was sent while issue was closed.
On 2016/01/08 02:17:22, jzern wrote:
> lgtm

thanks for the fix

Powered by Google App Engine
This is Rietveld 408576698