Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1558663002: Reland of Use ES2015-style TypedArray prototype chain (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Use ES2015-style TypedArray prototype chain (patchset #1 id:1 of https://codereview.chromium.org/1554523002/ ) Reason for revert: Should be fixed again with this Blink change to add NeedsManualRebaseline Original issue's description: > Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) > > Reason for revert: > [Sheriff] Changes layout tests. Please fix upstream first if intended. > > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 > > Original issue's description: > > Use ES2015-style TypedArray prototype chain > > > > This patch switches TypedArrays to use the prototype chain described > > in the ES2015 specification, which adds a %TypedArray% superclass above > > all individual TypedArray types. Most methods are defined on the > > superclass rather than the subclasses. > > > > In order to prevent a performance regression, a few methods are > > marked as inline. Inlining might prevent code which was previously > > monomorphic from becoming polymorphic, and it was specifically > > applied in places where methods became more polymorphic than before. > > Tests with realistic workloads would be nice to do before this > > ships in stable. > > > > This patch does not bring TypedArrays up to full spec compliance. In > > particular, @@species is not yet supported. > > > > R=cbruni > > BUG=v8:4085 > > LOG=Y > > > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > > Cr-Commit-Position: refs/heads/master@{#33050} > > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4085 > > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c > Cr-Commit-Position: refs/heads/master@{#33053} TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org BUG=v8:4085 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/e549c7a356ef730bad54bf24273134658f9a03a8 Cr-Commit-Position: refs/heads/master@{#33067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -195 lines) Patch
M src/js/array-iterator.js View 2 chunks +7 lines, -27 lines 0 comments Download
M src/js/typedarray.js View 3 chunks +103 lines, -70 lines 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/es6/built-in-accessor-names.js View 1 chunk +6 lines, -18 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 3 chunks +50 lines, -13 lines 0 comments Download
M test/mjsunit/es6/typed-array-iterator.js View 1 chunk +14 lines, -15 lines 0 comments Download
M test/mjsunit/es6/typedarray.js View 2 chunks +3 lines, -7 lines 0 comments Download
M test/mjsunit/es6/typedarray-of.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/typedarray-proto.js View 3 chunks +41 lines, -13 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/reflect-get-prototype-of.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/sharedarraybuffer.js View 2 chunks +4 lines, -7 lines 0 comments Download
M test/mjsunit/regress/regress-typedarray-length.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
Dan Ehrenberg
Created Reland of Use ES2015-style TypedArray prototype chain
4 years, 11 months ago (2015-12-30 21:02:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558663002/1
4 years, 11 months ago (2015-12-30 21:03:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 21:03:47 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558663002/1
4 years, 11 months ago (2015-12-30 21:04:52 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9349)
4 years, 11 months ago (2015-12-30 21:24:38 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558663002/1
4 years, 11 months ago (2015-12-30 21:33:46 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 22:10:32 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558663002/1
4 years, 11 months ago (2015-12-30 22:11:45 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 22:13:46 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e549c7a356ef730bad54bf24273134658f9a03a8 Cr-Commit-Position: refs/heads/master@{#33067}
4 years, 11 months ago (2015-12-30 22:14:31 UTC) #21
Michael Achenbach
4 years, 11 months ago (2015-12-31 08:35:49 UTC) #22
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698