Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1554523002: Revert of Use ES2015-style TypedArray prototype chain (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first if intended. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 Original issue's description: > Use ES2015-style TypedArray prototype chain > > This patch switches TypedArrays to use the prototype chain described > in the ES2015 specification, which adds a %TypedArray% superclass above > all individual TypedArray types. Most methods are defined on the > superclass rather than the subclasses. > > In order to prevent a performance regression, a few methods are > marked as inline. Inlining might prevent code which was previously > monomorphic from becoming polymorphic, and it was specifically > applied in places where methods became more polymorphic than before. > Tests with realistic workloads would be nice to do before this > ships in stable. > > This patch does not bring TypedArrays up to full spec compliance. In > particular, @@species is not yet supported. > > R=cbruni > BUG=v8:4085 > LOG=Y > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > Cr-Commit-Position: refs/heads/master@{#33050} TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c Cr-Commit-Position: refs/heads/master@{#33053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -271 lines) Patch
M src/js/array-iterator.js View 2 chunks +27 lines, -7 lines 0 comments Download
M src/js/typedarray.js View 3 chunks +70 lines, -103 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/built-in-accessor-names.js View 1 chunk +18 lines, -6 lines 0 comments Download
M test/mjsunit/es6/classes-subclass-builtins.js View 2 chunks +30 lines, -67 lines 0 comments Download
M test/mjsunit/es6/typed-array-iterator.js View 1 chunk +15 lines, -14 lines 0 comments Download
M test/mjsunit/es6/typedarray.js View 2 chunks +7 lines, -3 lines 0 comments Download
M test/mjsunit/es6/typedarray-of.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/typedarray-proto.js View 3 chunks +13 lines, -41 lines 0 comments Download
M test/mjsunit/get-prototype-of.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/reflect-get-prototype-of.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/sharedarraybuffer.js View 2 chunks +7 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-typedarray-length.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of Use ES2015-style TypedArray prototype chain
4 years, 11 months ago (2015-12-29 08:42:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554523002/1
4 years, 11 months ago (2015-12-29 08:42:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 08:43:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c Cr-Commit-Position: refs/heads/master@{#33053}
4 years, 11 months ago (2015-12-29 08:43:35 UTC) #6
Dan Ehrenberg
4 years, 11 months ago (2015-12-30 21:02:08 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1558663002/ by littledan@chromium.org.

The reason for reverting is: Should be fixed again with this Blink change to add
NeedsManualRebaseline.

Powered by Google App Engine
This is Rietveld 408576698