Cleanup: Remove double semicolons.

Cleanup: Remove double semicolons.

Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party

Committed: https://crrev.com/8d34e46c9a294b4d9a5f74e97d9e6536d34555c2
Cr-Commit-Position: refs/heads/master@{#367361}

[Lei Zhang, 2015-12-30 18:38:18]

Description was changed from

==========
Cleanup: Remove double semicolons.
==========

to

==========
Cleanup: Remove double semicolons.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Lei Zhang, 2015-12-30 18:43:35]

Description was changed from

==========
Cleanup: Remove double semicolons.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Cleanup: Remove double semicolons.
==========

[Lei Zhang, 2015-12-30 18:43:35]

thestig@chromium.org changed reviewers:
+ jam@chromium.org

[tfarina, 2015-12-30 19:04:49]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-12-30 19:04:50]

Lei, could you put in the CL description the commands you are running to
generate this? I believe it is a combination of grep + sed.

[tfarina, 2015-12-30 19:11:39]

https://codereview.chromium.org/1558633002/diff/20001/content/browser/loader/...
File content/browser/loader/async_resource_handler_browsertest.cc (right):

https://codereview.chromium.org/1558633002/diff/20001/content/browser/loader/...
content/browser/loader/async_resource_handler_browsertest.cc:55:
base::CompareCase::SENSITIVE)) {
The indentation seems off here. Run clang-format here?

[Lei Zhang, 2015-12-30 19:32:19]

Description was changed from

==========
Cleanup: Remove double semicolons.
==========

to

==========
Cleanup: Remove double semicolons.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Lei Zhang, 2015-12-30 19:35:44]

https://codereview.chromium.org/1558633002/diff/20001/content/browser/loader/...
File content/browser/loader/async_resource_handler_browsertest.cc (right):

https://codereview.chromium.org/1558633002/diff/20001/content/browser/loader/...
content/browser/loader/async_resource_handler_browsertest.cc:55:
base::CompareCase::SENSITIVE)) {
On 2015/12/30 19:11:38, tfarina wrote:
> The indentation seems off here. Run clang-format here?

Done.

[Lei Zhang, 2015-12-30 19:36:21]

Description was changed from

==========
Cleanup: Remove double semicolons.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Cleanup: Remove double semicolons.

Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party
==========

[tfarina, 2015-12-30 20:32:59]

I would revert the change to while loop in cloud_print. ;)

https://codereview.chromium.org/1558633002/diff/40001/cloud_print/service/win...
File cloud_print/service/win/chrome_launcher.cc (left):

https://codereview.chromium.org/1558633002/diff/40001/cloud_print/service/win...
cloud_print/service/win/chrome_launcher.cc:204: for (base::TimeDelta time_out =
default_time_out;;
really? Maybe just add a space after the first ';'? To indicate that the
'condition' is empty? Because otherwise, this foor loop is perfectly valid code
and saves a couple of lines.

[Lei Zhang, 2015-12-30 20:59:59]

https://codereview.chromium.org/1558633002/diff/40001/cloud_print/service/win...
File cloud_print/service/win/chrome_launcher.cc (left):

https://codereview.chromium.org/1558633002/diff/40001/cloud_print/service/win...
cloud_print/service/win/chrome_launcher.cc:204: for (base::TimeDelta time_out =
default_time_out;;
On 2015/12/30 20:32:59, tfarina wrote:
> really? Maybe just add a space after the first ';'? To indicate that the
> 'condition' is empty? Because otherwise, this foor loop is perfectly valid
code
> and saves a couple of lines.

Meh. For-loops without a condition are harder to read, since most of the time
readers expect a condition. Readers may need to do a double-take to make sure
they read it right. "while (1)" OTOH clearly implies the reader should look for
returns/breaks inside.

[jam, 2016-01-04 15:42:53]

lgtm

[Lei Zhang, 2016-01-04 19:09:15]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-01-04 19:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1558633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1558633002/40001

[commit-bot: I haz the power, 2016-01-04 20:35:10]

Description was changed from

==========
Cleanup: Remove double semicolons.

Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party
==========

to

==========
Cleanup: Remove double semicolons.

Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party
==========

[commit-bot: I haz the power, 2016-01-04 20:35:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-04 20:36:06]

Description was changed from

==========
Cleanup: Remove double semicolons.

Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party
==========

to

==========
Cleanup: Remove double semicolons.

Found with: git grep -l ';;$' | egrep '\.(cc|h)$' | grep -v third_party

Committed: https://crrev.com/8d34e46c9a294b4d9a5f74e97d9e6536d34555c2
Cr-Commit-Position: refs/heads/master@{#367361}
==========

[commit-bot: I haz the power, 2016-01-04 20:36:07]

Patchset 3 (id:??) landed as
https://crrev.com/8d34e46c9a294b4d9a5f74e97d9e6536d34555c2
Cr-Commit-Position: refs/heads/master@{#367361}