Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1558493002: Reland: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, kinuko+watch, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Make ScrollbarThemeAura selectively invalidate scrollbar parts. In particular: - when hovering or pressing the thumb, repaint only the thumb - when thumb position changes, repaint the track only if it changes (e.g. due to a button being disabled upon reaching the end) BUG=549277 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_oilpan_rel,mac_blink_oilpan_rel Committed: https://crrev.com/54342454be5d73c64aa47b57facd880ba8df2b36 Cr-Commit-Position: refs/heads/master@{#367105}

Patch Set 1 #

Patch Set 2 : fix ScrollableAreaTest.InvalidatesCompositedScrollbarsIfPartsNeedRepaint for Oilpan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -94 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm View 1 chunk +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableAreaTest.cpp View 1 6 chunks +111 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 5 chunks +13 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 5 chunks +18 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarTheme.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeAura.cpp View 3 chunks +100 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jbroman
Reland of https://codereview.chromium.org/1525803002/. Change is trivial (one-line addition to ScrollableAreaTest.cpp). Verified locally, and added bots ...
4 years, 11 months ago (2015-12-29 20:35:41 UTC) #3
skobes
lgtm
4 years, 11 months ago (2015-12-29 21:00:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558493002/20001
4 years, 11 months ago (2015-12-29 21:10:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-29 21:53:13 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 21:54:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54342454be5d73c64aa47b57facd880ba8df2b36
Cr-Commit-Position: refs/heads/master@{#367105}

Powered by Google App Engine
This is Rietveld 408576698