third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp - Issue 1558493002: Reland: Make ScrollbarThemeAura selectively invalidate scrollbar parts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp

Issue 1558493002: Reland: Make ScrollbarThemeAura selectively invalidate scrollbar parts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix ScrollableAreaTest.InvalidatesCompositedScrollbarsIfPartsNeedRepaint for Oilpan Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp b/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp

index 1f1c76b42b9e63b0f3f50deed667f03d7c99ab7a..227801f6f971732285c4abefc249f7422576de35 100644

--- a/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp

@@ -66,8 +66,7 @@ void WebScrollbarThemePainter::paintTrackBackground(WebCanvas* canvas, const Web

pictureBuilder.context().setDeviceScaleFactor(m_deviceScaleFactor);

m_theme->paintTrackBackground(pictureBuilder.context(), *m_scrollbar, intRect);

pictureBuilder.endRecording()->playback(canvas);

- if (!m_theme->shouldRepaintAllPartsOnInvalidation())

- m_scrollbar->setTrackNeedsRepaint(false);

+ m_scrollbar->setTrackNeedsRepaint(false);

}

void WebScrollbarThemePainter::paintBackTrackPart(WebCanvas* canvas, const WebRect& rect)

@@ -140,8 +139,7 @@ void WebScrollbarThemePainter::paintThumb(WebCanvas* canvas, const WebRect& rect

pictureBuilder.context().setDeviceScaleFactor(m_deviceScaleFactor);

m_theme->paintThumb(pictureBuilder.context(), *m_scrollbar, intRect);

pictureBuilder.endRecording()->playback(canvas);

- if (!m_theme->shouldRepaintAllPartsOnInvalidation())

- m_scrollbar->setThumbNeedsRepaint(false);

+ m_scrollbar->setThumbNeedsRepaint(false);

}

WebScrollbarThemePainter::WebScrollbarThemePainter(ScrollbarTheme& theme, Scrollbar& scrollbar, float deviceScaleFactor)

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm » ('j') | no next file with comments »