Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1558153002: [Interpreter] Pass correct closure argument when creating block context. (Closed)

Created:
4 years, 11 months ago by mythria
Modified:
4 years, 11 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Pass correct closure argument when creating block context. After this change, https://codereview.chromium.org/1475383002 we should not pass Smi 0 for a closure and expect runtime to look it up. We should pass the correct argument always. BUG=v8:4280 LOG=N Committed: https://crrev.com/47d7ae1154bded0b4f3cb4171bbd3152018699ea Cr-Commit-Position: refs/heads/master@{#33117}

Patch Set 1 #

Patch Set 2 : Fixes test262.status with failing tests on bots #

Total comments: 2

Patch Set 3 : orders test262.status in alphabetical order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M src/interpreter/bytecode-generator.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 2 4 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mythria
PTAL Thanks, Mythri
4 years, 11 months ago (2016-01-05 14:12:16 UTC) #2
rmcilroy
LGTM, thanks! https://codereview.chromium.org/1558153002/diff/20001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1558153002/diff/20001/test/test262/test262.status#newcode646 test/test262/test262.status:646: 'language/statements/let/block-local-closure-get-before-initialization': [SKIP], Alphabetical ordering please.
4 years, 11 months ago (2016-01-05 14:33:28 UTC) #3
mythria
Thanks, done. https://codereview.chromium.org/1558153002/diff/20001/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/1558153002/diff/20001/test/test262/test262.status#newcode646 test/test262/test262.status:646: 'language/statements/let/block-local-closure-get-before-initialization': [SKIP], On 2016/01/05 14:33:28, rmcilroy wrote: ...
4 years, 11 months ago (2016-01-05 15:05:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558153002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558153002/40001
4 years, 11 months ago (2016-01-05 15:33:58 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-05 15:35:27 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 15:35:42 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/47d7ae1154bded0b4f3cb4171bbd3152018699ea
Cr-Commit-Position: refs/heads/master@{#33117}

Powered by Google App Engine
This is Rietveld 408576698