[compiler] Always pass closure argument to with, catch and block context creation.

[compiler] Always pass closure argument to with, catch and block context creation.

Up until now we sometimes pass Smi 0 around as closure and expect the
runtime to translate that appropriately. But we need to be careful in
some places to not confuse the Smi 0 with a real closure. However, we
could instead just pass the correct closure extracted from the native
context.

This addresses three long-standing TODOs in the JSTypedLowering pass.

Drive-by-fix: Further unify error message reporting for ToObject (we had
a special message in case of ToObject error in with context creation).

R=yangguo@chromium.org

Committed: https://crrev.com/d3e5db04287b0b853e28552119e4177eb3bf10b9
Cr-Commit-Position: refs/heads/master@{#32336}

[Benedikt Meurer, 2015-11-26 12:44:03]

Hey Yang,

Here's some cleanup for the context creation runtime entries, avoiding a magic
Smi 0 in the compilers.
Please take a look.

Thanks,
Benedikt

[Yang, 2015-11-26 12:46:04]

lgtm with comment.

https://codereview.chromium.org/1475383002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (left):

https://codereview.chromium.org/1475383002/diff/1/src/runtime/runtime-scopes....
src/runtime/runtime-scopes.cc:719: isolate,
NewTypeError(MessageTemplate::kWithExpression, handle));
Please also remove this message template from messages.h

[Benedikt Meurer, 2015-11-26 12:47:50]

https://codereview.chromium.org/1475383002/diff/1/src/runtime/runtime-scopes.cc
File src/runtime/runtime-scopes.cc (left):

https://codereview.chromium.org/1475383002/diff/1/src/runtime/runtime-scopes....
src/runtime/runtime-scopes.cc:719: isolate,
NewTypeError(MessageTemplate::kWithExpression, handle));
On 2015/11/26 12:46:04, Yang wrote:
> Please also remove this message template from messages.h

Done.

[Benedikt Meurer, 2015-11-26 12:47:54]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2015-11-26 12:47:54]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1475383002/#ps20001
(title: "Remove WithExpression from messages.h")

[commit-bot: I haz the power, 2015-11-26 12:48:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1475383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1475383002/20001

[commit-bot: I haz the power, 2015-11-26 13:35:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-26 13:35:34]

Description was changed from

==========
[compiler] Always pass closure argument to with, catch and block context
creation.

Up until now we sometimes pass Smi 0 around as closure and expect the
runtime to translate that appropriately. But we need to be careful in
some places to not confuse the Smi 0 with a real closure. However, we
could instead just pass the correct closure extracted from the native
context.

This addresses three long-standing TODOs in the JSTypedLowering pass.

Drive-by-fix: Further unify error message reporting for ToObject (we had
a special message in case of ToObject error in with context creation).

R=yangguo@chromium.org
==========

to

==========
[compiler] Always pass closure argument to with, catch and block context
creation.

Up until now we sometimes pass Smi 0 around as closure and expect the
runtime to translate that appropriately. But we need to be careful in
some places to not confuse the Smi 0 with a real closure. However, we
could instead just pass the correct closure extracted from the native
context.

This addresses three long-standing TODOs in the JSTypedLowering pass.

Drive-by-fix: Further unify error message reporting for ToObject (we had
a special message in case of ToObject error in with context creation).

R=yangguo@chromium.org

Committed: https://crrev.com/d3e5db04287b0b853e28552119e4177eb3bf10b9
Cr-Commit-Position: refs/heads/master@{#32336}
==========

[commit-bot: I haz the power, 2015-11-26 13:35:34]

Patchset 2 (id:??) landed as
https://crrev.com/d3e5db04287b0b853e28552119e4177eb3bf10b9
Cr-Commit-Position: refs/heads/master@{#32336}