Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1549103002: Make more CPDF_Parser method const. (Closed)

Created:
4 years, 12 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : more cleanup #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : remove unused CheckDirectType() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -71 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 4 chunks +11 lines, -17 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 3 4 5 17 chunks +50 lines, -52 lines 0 comments Download
M fpdfsdk/include/fsdk_annothandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/include/fsdk_baseannot.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-04 19:54:19 UTC) #2
Wei Li
lgtm https://codereview.chromium.org/1549103002/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1549103002/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode3827 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3827: if (m_WordSize < sizeof(m_WordBuffer) - 1) Should be ...
4 years, 11 months ago (2016-01-04 20:11:48 UTC) #3
Lei Zhang
Please see patch set 3. https://codereview.chromium.org/1549103002/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1549103002/diff/20001/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode3827 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:3827: if (m_WordSize < sizeof(m_WordBuffer) ...
4 years, 11 months ago (2016-01-05 01:27:53 UTC) #4
Wei Li
lgtm It is much cleaner now. Thanks for the work!
4 years, 11 months ago (2016-01-05 18:46:08 UTC) #5
Lei Zhang
I also removed CheckDirectType() since we removed all the callers.
4 years, 11 months ago (2016-01-05 23:09:30 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-05 23:10:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
a3235d0f5ca92c89b1de0f135a05e9891e499fb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698