Make use of InvalidationService

sync/tools/testserver/xmppserver.py

Index: sync/tools/testserver/xmppserver.py
diff --git a/sync/tools/testserver/xmppserver.py b/sync/tools/testserver/xmppserver.py
index f9599c0cd090245c93e6cab61d0f477e9cd2eb8a..cdc7fc6b863ee8bce893e9bb20d9f08a1e8f52c9 100644
--- a/sync/tools/testserver/xmppserver.py
+++ b/sync/tools/testserver/xmppserver.py
@@ -573,6 +573,9 @@ class XmppServer(asyncore.dispatcher):
 
   def SetAuthenticated(self, auth_valid):
     self._authenticated = auth_valid
+    if not self._authenticated:

[akalin, 2013/05/24 22:58:46]

why did this become necessary?

[rlarocque, 2013/05/29 00:37:55]

This was written a while ago, so I don't remember all the details.  

I think it's related to SyncErrorTest.XmppAuthErrorTest:
  ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";

  TriggerXmppAuthError();

  ASSERT_FALSE(GetClient(0)->SetupSync());

  ASSERT_EQ(GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS,
            GetClient(0)->service()->GetAuthError().state());

I think the issue was that the python XMPP server only sent auth failures if
they happened when a connection was first established.  If the
self._authenticated flag is set after that point, it has no effect.

My patch probably changed the time at which the connection is established, so
the TriggerXmppAuthError() call had no effect.  Closing the connection here
makes the auth error visible once again.

[akalin, 2013/06/04 19:23:54]

Can you add a comment to this effect in this file?

+      for connection in self._handshake_done_connections:
+        connection.close()
 
   def GetAuthenticated(self):
     return self._authenticated