Make use of InvalidationService

sync/tools/testserver/xmppserver.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A bare-bones and non-compliant XMPP server.
 
 Just enough of the protocol is implemented to get it to work with
 Chrome's sync notification system.
 """
 
@@ skipping 555 matching lines @@
     Args:
       channel: The channel on which to send the notification.
       data: The notification payload.
     """
     notification_stanza = self.MakeNotification(channel, data)
     self.ForwardNotification(None, notification_stanza)
     notification_stanza.unlink()
 
   def SetAuthenticated(self, auth_valid):
     self._authenticated = auth_valid
+    if not self._authenticated:

[akalin, 2013/05/24 22:58:46]

why did this become necessary?

[rlarocque, 2013/05/29 00:37:55]

This was written a while ago, so I don't remember all the details.  

I think it's related to SyncErrorTest.XmppAuthErrorTest:
  ASSERT_TRUE(SetupClients()) << "SetupClients() failed.";

  TriggerXmppAuthError();

  ASSERT_FALSE(GetClient(0)->SetupSync());

  ASSERT_EQ(GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS,
            GetClient(0)->service()->GetAuthError().state());

I think the issue was that the python XMPP server only sent auth failures if
they happened when a connection was first established.  If the
self._authenticated flag is set after that point, it has no effect.

My patch probably changed the time at which the connection is established, so
the TriggerXmppAuthError() call had no effect.  Closing the connection here
makes the auth error visible once again.

[akalin, 2013/06/04 19:23:54]

Can you add a comment to this effect in this file?

+      for connection in self._handshake_done_connections:
+        connection.close()
 
   def GetAuthenticated(self):
     return self._authenticated
 
   # XmppConnection delegate methods.
   def OnXmppHandshakeDone(self, xmpp_connection):
     self._handshake_done_connections.add(xmpp_connection)
 
   def OnXmppConnectionClosed(self, xmpp_connection):
     self._connections.discard(xmpp_connection)
     self._handshake_done_connections.discard(xmpp_connection)
 
   def ForwardNotification(self, unused_xmpp_connection, notification_stanza):
     if self._notifications_enabled:
       for connection in self._handshake_done_connections:
         print 'Sending notification to %s' % connection
         connection.ForwardNotification(notification_stanza)
     else:
       print 'Notifications disabled; dropping notification'