Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: sync/internal_api/test/fake_sync_manager.cc

Issue 15580002: Make use of InvalidationService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First set of review fixes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/test/fake_sync_manager.cc
diff --git a/sync/internal_api/test/fake_sync_manager.cc b/sync/internal_api/test/fake_sync_manager.cc
index 674c5be10ef40570cb4092f78f324b2aa2cbe3f4..1c7eb62f24233eea81e09fdb6ed92460da15df36 100644
--- a/sync/internal_api/test/fake_sync_manager.cc
+++ b/sync/internal_api/test/fake_sync_manager.cc
@@ -61,25 +61,6 @@ ConfigureReason FakeSyncManager::GetAndResetConfigureReason() {
return reason;
}
-void FakeSyncManager::Invalidate(
- const ObjectIdInvalidationMap& invalidation_map) {
- if (!sync_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&FakeSyncManager::InvalidateOnSyncThread,
- base::Unretained(this), invalidation_map))) {
- NOTREACHED();
- }
-}
-
-void FakeSyncManager::UpdateInvalidatorState(InvalidatorState state) {
- if (!sync_task_runner_->PostTask(
- FROM_HERE,
- base::Bind(&FakeSyncManager::UpdateInvalidatorStateOnSyncThread,
- base::Unretained(this), state))) {
- NOTREACHED();
- }
-}
-
void FakeSyncManager::WaitForSyncThread() {
// Post a task to |sync_task_runner_| and block until it runs.
base::RunLoop run_loop;
@@ -103,7 +84,6 @@ void FakeSyncManager::Init(
ExtensionsActivityMonitor* extensions_activity_monitor,
ChangeDelegate* change_delegate,
const SyncCredentials& credentials,
- scoped_ptr<Invalidator> invalidator,
const std::string& invalidator_client_id,
const std::string& restored_key_for_bootstrapping,
const std::string& restored_keystore_key_for_bootstrapping,
@@ -160,31 +140,6 @@ void FakeSyncManager::UpdateCredentials(const SyncCredentials& credentials) {
NOTIMPLEMENTED();
}
-void FakeSyncManager::UpdateEnabledTypes(ModelTypeSet types) {
- enabled_types_ = types;
-}
-
-void FakeSyncManager::RegisterInvalidationHandler(
- InvalidationHandler* handler) {
- registrar_.RegisterHandler(handler);
-}
-
-void FakeSyncManager::UpdateRegisteredInvalidationIds(
- InvalidationHandler* handler,
- const ObjectIdSet& ids) {
- registrar_.UpdateRegisteredIds(handler, ids);
-}
-
-void FakeSyncManager::UnregisterInvalidationHandler(
- InvalidationHandler* handler) {
- registrar_.UnregisterHandler(handler);
-}
-
-void FakeSyncManager::AcknowledgeInvalidation(const invalidation::ObjectId& id,
- const AckHandle& ack_handle) {
- // Do nothing.
-}
-
void FakeSyncManager::StartSyncingNormally(
const ModelSafeRoutingInfo& routing_info) {
// Do nothing.
@@ -198,9 +153,9 @@ void FakeSyncManager::ConfigureSyncer(
const base::Closure& ready_task,
const base::Closure& retry_task) {
last_configure_reason_ = reason;
- ModelTypeSet enabled_types = GetRoutingInfoTypes(new_routing_info);
+ enabled_types_ = GetRoutingInfoTypes(new_routing_info);
ModelTypeSet disabled_types = Difference(
- ModelTypeSet::All(), enabled_types);
+ ModelTypeSet::All(), enabled_types_);
ModelTypeSet success_types = types_to_config;
success_types.RemoveAll(configure_fail_types_);
@@ -288,20 +243,17 @@ void FakeSyncManager::RefreshTypes(ModelTypeSet types) {
last_refresh_request_types_ = types;
}
-void FakeSyncManager::InvalidateOnSyncThread(
- const ObjectIdInvalidationMap& invalidation_map) {
- DCHECK(sync_task_runner_->RunsTasksOnCurrentThread());
- registrar_.DispatchInvalidationsToHandlers(invalidation_map);
-}
-
-void FakeSyncManager::UpdateInvalidatorStateOnSyncThread(
- InvalidatorState state) {
- DCHECK(sync_task_runner_->RunsTasksOnCurrentThread());
- registrar_.UpdateInvalidatorState(state);
+void FakeSyncManager::OnIncomingInvalidation(
+ const ObjectIdInvalidationMap& invalidation_map) {
+ // Do nothing.
}
ModelTypeSet FakeSyncManager::GetLastRefreshRequestTypes() {
return last_refresh_request_types_;
}
+void FakeSyncManager::OnInvalidatorStateChange(InvalidatorState state) {
+ // Do nothing.
+}
+
} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698