Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: sync/internal_api/sync_manager_impl_unittest.cc

Issue 15580002: Make use of InvalidationService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First set of review fixes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/sync_manager_impl_unittest.cc
diff --git a/sync/internal_api/sync_manager_impl_unittest.cc b/sync/internal_api/sync_manager_impl_unittest.cc
index 01b776e2f299982f74e1ba70172ab35977ddf75b..73748c54388043edb386b23d58f4331b53e5762d 100644
--- a/sync/internal_api/sync_manager_impl_unittest.cc
+++ b/sync/internal_api/sync_manager_impl_unittest.cc
@@ -46,7 +46,6 @@
#include "sync/js/js_reply_handler.h"
#include "sync/js/js_test_util.h"
#include "sync/notifier/fake_invalidation_handler.h"
-#include "sync/notifier/fake_invalidator.h"
#include "sync/notifier/invalidation_handler.h"
#include "sync/notifier/invalidator.h"
#include "sync/protocol/bookmark_specifics.pb.h"
@@ -789,14 +788,12 @@ class SyncManagerTest : public testing::Test,
};
SyncManagerTest()
- : fake_invalidator_(NULL),
- sync_manager_("Test sync manager") {
+ : sync_manager_("Test sync manager") {
switches_.encryption_method =
InternalComponentsFactory::ENCRYPTION_KEYSTORE;
}
virtual ~SyncManagerTest() {
- EXPECT_FALSE(fake_invalidator_);
}
// Test implementation.
@@ -807,8 +804,6 @@ class SyncManagerTest : public testing::Test,
credentials.email = "foo@bar.com";
credentials.sync_token = "sometoken";
- fake_invalidator_ = new FakeInvalidator();
-
sync_manager_.AddObserver(&manager_observer_);
EXPECT_CALL(manager_observer_, OnInitializationComplete(_, _, _, _)).
WillOnce(SaveArg<0>(&js_backend_));
@@ -831,7 +826,6 @@ class SyncManagerTest : public testing::Test,
&extensions_activity_monitor_,
this,
credentials,
- scoped_ptr<Invalidator>(fake_invalidator_),
"fake_invalidator_client_id",
std::string(),
std::string(), // bootstrap tokens
@@ -850,17 +844,11 @@ class SyncManagerTest : public testing::Test,
sync_manager_.GetUserShare(), i->first);
}
PumpLoop();
-
- EXPECT_TRUE(fake_invalidator_->IsHandlerRegistered(&sync_manager_));
}
void TearDown() {
sync_manager_.RemoveObserver(&manager_observer_);
sync_manager_.ShutdownOnSyncThread();
- // We can't assert that |sync_manager_| isn't registered with
- // |fake_invalidator_| anymore because |fake_invalidator_| is now
- // destroyed.
- fake_invalidator_ = NULL;
PumpLoop();
}
@@ -1026,7 +1014,6 @@ class SyncManagerTest : public testing::Test,
protected:
FakeEncryptor encryptor_;
TestUnrecoverableErrorHandler handler_;
- FakeInvalidator* fake_invalidator_;
SyncManagerImpl sync_manager_;
WeakHandle<JsBackend> js_backend_;
StrictMock<SyncManagerObserverMock> manager_observer_;
@@ -1034,29 +1021,6 @@ class SyncManagerTest : public testing::Test,
InternalComponentsFactory::Switches switches_;
};
-TEST_F(SyncManagerTest, UpdateEnabledTypes) {
- ModelSafeRoutingInfo routes;
- GetModelSafeRoutingInfo(&routes);
- const ModelTypeSet enabled_types = GetRoutingInfoTypes(routes);
- sync_manager_.UpdateEnabledTypes(enabled_types);
- EXPECT_EQ(ModelTypeSetToObjectIdSet(enabled_types),
- fake_invalidator_->GetRegisteredIds(&sync_manager_));
-}
-
-TEST_F(SyncManagerTest, RegisterInvalidationHandler) {
- FakeInvalidationHandler fake_handler;
- sync_manager_.RegisterInvalidationHandler(&fake_handler);
- EXPECT_TRUE(fake_invalidator_->IsHandlerRegistered(&fake_handler));
-
- const ObjectIdSet& ids =
- ModelTypeSetToObjectIdSet(ModelTypeSet(BOOKMARKS, PREFERENCES));
- sync_manager_.UpdateRegisteredInvalidationIds(&fake_handler, ids);
- EXPECT_EQ(ids, fake_invalidator_->GetRegisteredIds(&fake_handler));
-
- sync_manager_.UnregisterInvalidationHandler(&fake_handler);
- EXPECT_FALSE(fake_invalidator_->IsHandlerRegistered(&fake_handler));
-}
-
TEST_F(SyncManagerTest, ProcessJsMessage) {
const JsArgList kNoArgs;

Powered by Google App Engine
This is Rietveld 408576698