Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1557823002: Simplify xcode_settings block in common.gypi a bit. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify xcode_settings block in common.gypi a bit. - Mac builds are always 64-bit nowaydays - Collapse two adjacent OS==ios conditions No intended behavior change. BUG=none Committed: https://crrev.com/ea6bdacc04396d48bd80fc40cf490ad238d88e4d Cr-Commit-Position: refs/heads/master@{#367314}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M build/common.gypi View 3 chunks +3 lines, -17 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
Nico
4 years, 11 months ago (2016-01-03 22:19:23 UTC) #2
Mark Mentovai
LGTM https://codereview.chromium.org/1557823002/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/1557823002/diff/1/build/common.gypi#oldcode6412 build/common.gypi:6412: 'i386' Double-check with someone from remoting that they’re ...
4 years, 11 months ago (2016-01-04 16:15:49 UTC) #3
Nico
https://codereview.chromium.org/1557823002/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/1557823002/diff/1/build/common.gypi#oldcode6412 build/common.gypi:6412: 'i386' On 2016/01/04 16:15:49, Mark Mentovai wrote: > Double-check ...
4 years, 11 months ago (2016-01-04 16:29:54 UTC) #4
Mark Mentovai
I didn’t know if they were setting ARCHS or if they had some double-build-plus-lipo thing. ...
4 years, 11 months ago (2016-01-04 16:31:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557823002/1
4 years, 11 months ago (2016-01-04 16:33:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 16:38:04 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 16:39:32 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea6bdacc04396d48bd80fc40cf490ad238d88e4d
Cr-Commit-Position: refs/heads/master@{#367314}

Powered by Google App Engine
This is Rietveld 408576698