Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: build/common.gypi

Issue 1557823002: Simplify xcode_settings block in common.gypi a bit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index cbea95780ec9259301466486890457d51b26eb90..1351edcfaf7ca8f2eda06126aec181c9ba133ca5 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -6373,6 +6373,7 @@
# configured SDK to show properly in the Xcode UI, SDKROOT must be set
# here at the project level.
['OS=="mac"', {
+ 'ARCHS': [ 'x86_64' ],
'conditions': [
['mac_sdk_path==""', {
'SDKROOT': 'macosx<(mac_sdk)', # -isysroot
@@ -6382,6 +6383,8 @@
],
}],
['OS=="ios"', {
+ # Target both iPhone and iPad.
+ 'TARGETED_DEVICE_FAMILY': '1,2',
'conditions': [
['ios_sdk_path==""', {
'conditions': [
@@ -6397,23 +6400,6 @@
}],
],
}],
- ['OS=="ios"', {
- # Target both iPhone and iPad.
- 'TARGETED_DEVICE_FAMILY': '1,2',
- }, { # OS!="ios"
- 'conditions': [
- ['target_arch=="x64"', {
- 'ARCHS': [
- 'x86_64'
- ],
- }],
- ['target_arch=="ia32"', {
- 'ARCHS': [
- 'i386'
Mark Mentovai 2016/01/04 16:15:49 Double-check with someone from remoting that they’
Nico 2016/01/04 16:29:54 Would that be a problem? They used to locally set
- ],
- }],
- ],
- }],
],
# The Xcode generator will look for an xcode_settings section at the root
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698