Unify validation for TexSubImage{2D|3D}

Unify validation for TexSubImage{2D|3D}

This CL unifies validation for TexSubImage2D/3D and fixes texSubimage3D
cases in deqp/functional/gles3/negativetextureapi.html.

BUG=295792
TEST=deqp/functional/gles3/negativetextureapi.html

Committed: https://crrev.com/3e6e2f57a2f9df325c98e82d3198d9c5a41b2f1a
Cr-Commit-Position: refs/heads/master@{#367216}

[qiankun, 2015-12-30 15:09:31]

qiankun.miao@intel.com changed reviewers:
+ bajones@chromium.org, kbr@chromium.org, yunchao.he@intel.com, zmo@chromium.org

[qiankun, 2015-12-30 15:09:32]

PTAL.

[Zhenyao Mo, 2015-12-30 20:17:05]

https://codereview.chromium.org/1557603002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1557603002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:938: }
if (pixels->data()->bufferBase()->isNeutered()) {
        synthesizeGLError(GL_INVALID_VALUE, "texSubImage3D", "The source data
has been neutered.");
        return;
    }

https://codereview.chromium.org/1557603002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:966: if
(isContextLost() || !image || !validateHTMLImageElement("texSubImage3D", image,
exceptionState)
Get rid of !image

[qiankun, 2015-12-30 23:15:07]

Thanks zhenyao, I fixed your comments. PTAL.

https://codereview.chromium.org/1557603002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1557603002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:938: }
On 2015/12/30 20:17:05, Zhenyao Mo wrote:
> if (pixels->data()->bufferBase()->isNeutered()) {
>         synthesizeGLError(GL_INVALID_VALUE, "texSubImage3D", "The source data
> has been neutered.");
>         return;
>     }

Done.

https://codereview.chromium.org/1557603002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:966: if
(isContextLost() || !image || !validateHTMLImageElement("texSubImage3D", image,
exceptionState)
On 2015/12/30 20:17:05, Zhenyao Mo wrote:
> Get rid of !image

Done.

[Zhenyao Mo, 2015-12-30 23:24:35]

lgtm

[qiankun, 2015-12-30 23:27:11]

The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-30 23:28:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557603002/20001

[commit-bot: I haz the power, 2015-12-31 01:00:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-31 01:00:20]

Dry run: This issue passed the CQ dry run.

[qiankun, 2015-12-31 01:06:25]

The CQ bit was checked by qiankun.miao@intel.com

[commit-bot: I haz the power, 2015-12-31 01:07:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557603002/20001

[commit-bot: I haz the power, 2015-12-31 01:16:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-31 01:18:08]

Description was changed from

==========
Unify validation for TexSubImage{2D|3D}

This CL unifies validation for TexSubImage2D/3D and fixes texSubimage3D
cases in deqp/functional/gles3/negativetextureapi.html.

BUG=295792
TEST=deqp/functional/gles3/negativetextureapi.html
==========

to

==========
Unify validation for TexSubImage{2D|3D}

This CL unifies validation for TexSubImage2D/3D and fixes texSubimage3D
cases in deqp/functional/gles3/negativetextureapi.html.

BUG=295792
TEST=deqp/functional/gles3/negativetextureapi.html

Committed: https://crrev.com/3e6e2f57a2f9df325c98e82d3198d9c5a41b2f1a
Cr-Commit-Position: refs/heads/master@{#367216}
==========

[commit-bot: I haz the power, 2015-12-31 01:18:09]

Patchset 2 (id:??) landed as
https://crrev.com/3e6e2f57a2f9df325c98e82d3198d9c5a41b2f1a
Cr-Commit-Position: refs/heads/master@{#367216}