Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 1557603002: Unify validation for TexSubImage{2D|3D} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: handle neutered image data Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "modules/webgl/WebGLExtension.h" 8 #include "modules/webgl/WebGLExtension.h"
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 10
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 // Generate GL error and return false if parameters are illegal. 189 // Generate GL error and return false if parameters are illegal.
190 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, GLenum target, GLenum attachment); 190 bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, GLenum target, GLenum attachment);
191 191
192 bool validateClearBuffer(const char* functionName, GLenum buffer, GLsizei le ngth); 192 bool validateClearBuffer(const char* functionName, GLenum buffer, GLsizei le ngth);
193 193
194 enum TexStorageType { 194 enum TexStorageType {
195 TexStorageType2D, 195 TexStorageType2D,
196 TexStorageType3D, 196 TexStorageType3D,
197 }; 197 };
198 bool validateTexStorage(const char*, GLenum, GLsizei, GLenum, GLsizei, GLsiz ei, GLsizei, TexStorageType); 198 bool validateTexStorage(const char*, GLenum, GLsizei, GLenum, GLsizei, GLsiz ei, GLsizei, TexStorageType);
199 bool validateTexSubImage3D(const char*, GLenum target, GLint level, GLint xo ffset, GLint yoffset, GLint zoffset, GLenum format, GLenum type, GLsizei width, GLsizei height, GLsizei depth);
200 199
201 bool validateUniformBlockIndex(const char*, WebGLProgram*, GLuint); 200 bool validateUniformBlockIndex(const char*, WebGLProgram*, GLuint);
202 201
203 ScriptValue getInt64Parameter(ScriptState*, GLenum); 202 ScriptValue getInt64Parameter(ScriptState*, GLenum);
204 203
205 void texSubImage3DImpl(GLenum, GLint, GLint, GLint, GLint, GLenum, GLenum, I mage*, WebGLImageConversion::ImageHtmlDomSource, bool, bool); 204 void texSubImage3DImpl(GLenum, GLint, GLint, GLint, GLint, GLenum, GLenum, I mage*, WebGLImageConversion::ImageHtmlDomSource, bool, bool);
206 void samplerParameter(WebGLSampler*, GLenum, GLfloat, GLint, bool); 205 void samplerParameter(WebGLSampler*, GLenum, GLfloat, GLint, bool);
207 206
208 bool isBufferBoundToTransformFeedback(WebGLBuffer*); 207 bool isBufferBoundToTransformFeedback(WebGLBuffer*);
209 bool isBufferBoundToNonTransformFeedback(WebGLBuffer*); 208 bool isBufferBoundToNonTransformFeedback(WebGLBuffer*);
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 GLint m_unpackSkipImages; 277 GLint m_unpackSkipImages;
279 }; 278 };
280 279
281 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context, 280 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context,
282 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 281 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
283 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ; 282 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ;
284 283
285 } // namespace blink 284 } // namespace blink
286 285
287 #endif 286 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698