Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 1557533002: Eliminate excessive increment of deoptimization counters (e.g., with deep recursion of deoptimized … (Closed)

Created:
4 years, 11 months ago by srdjan
Modified:
4 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Eliminate excessive increment of deoptimization counters (e.g., with deep recursion of deoptimized function). Instead increment deoptimization_count for all (inlined) functions at deoptimization point if deoptimization was triggered from function's optimized code. Cases where that is not the case are OSR codes, lazy-deopts and code disabling due to loading/finalizing classes or guard invalidation. Rename deoptimization_counter_threshold to max_deoptimization_counter_threshold. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/6d0be9b1ecc31938ec1c34349cb4940948441c51

Patch Set 1 #

Patch Set 2 : Eliminate excessive increment of deoptimization counters #

Patch Set 3 : r #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -20 lines) Patch
M runtime/vm/code_generator.cc View 1 2 6 chunks +18 lines, -4 lines 0 comments Download
M runtime/vm/compiler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/deferred_objects.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 4 chunks +7 lines, -1 line 0 comments Download
M runtime/vm/deopt_instructions.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
srdjan
4 years, 11 months ago (2015-12-29 23:03:11 UTC) #3
Cutch
LGTM!
4 years, 11 months ago (2015-12-29 23:13:13 UTC) #4
srdjan
4 years, 11 months ago (2015-12-29 23:48:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6d0be9b1ecc31938ec1c34349cb4940948441c51 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698