runtime/vm/flow_graph_inliner.cc - Issue 1557533002: Eliminate excessive increment of deoptimization counters (e.g., with deep recursion of deoptimized …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 1557533002: Eliminate excessive increment of deoptimization counters (e.g., with deep recursion of deoptimized … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: r Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_inliner.cc

diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc

index 55876270dc63f3030a39a49495035a27c2bb3840..bc5d7bc863c7c3efee31deefc275e661a38a3642 100644

--- a/runtime/vm/flow_graph_inliner.cc

+++ b/runtime/vm/flow_graph_inliner.cc

@@ -59,7 +59,7 @@ DEFINE_FLAG(bool, enable_inlining_annotations, false,

"Enable inlining annotations");

DECLARE_FLAG(bool, compiler_stats);

-DECLARE_FLAG(int, deoptimization_counter_threshold);

+DECLARE_FLAG(int, max_deoptimization_counter_threshold);

DECLARE_FLAG(bool, polymorphic_with_deopt);

DECLARE_FLAG(bool, print_flow_graph);

DECLARE_FLAG(bool, print_flow_graph_optimized);

@@ -639,7 +639,7 @@ class CallSiteInliner : public ValueObject {

// Abort if this function has deoptimized too much.

if (function.deoptimization_counter() >=

- FLAG_deoptimization_counter_threshold) {

+ FLAG_max_deoptimization_counter_threshold) {

function.set_is_inlinable(false);

TRACE_INLINING(THR_Print(" Bailout: deoptimization threshold\n"));

PRINT_INLINING_TREE("Deoptimization threshold exceeded",

« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »