Fixes for OSThread creation shutdown race.

Fixes for OSThread creation shutdown race.

Also, backs out bad change to the thread pool. The real fix is to
move the disable of OSThread creation until after the thread pool
shuts down.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/18929970a03d86cc6b97c3524809dc3cb095f1c8

[zra, 2016-01-04 18:37:51]

zra@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-01-04 23:07:55]

lgtm

https://codereview.chromium.org/1557033002/diff/1/runtime/vm/os_thread.cc
File runtime/vm/os_thread.cc (right):

https://codereview.chromium.org/1557033002/diff/1/runtime/vm/os_thread.cc#new...
runtime/vm/os_thread.cc:131: }
Since everything inside the 'if statement' is commented out why not put the
whole statement under #if 0....#endif

[zra, 2016-01-04 23:21:53]

https://codereview.chromium.org/1557033002/diff/1/runtime/vm/os_thread.cc
File runtime/vm/os_thread.cc (right):

https://codereview.chromium.org/1557033002/diff/1/runtime/vm/os_thread.cc#new...
runtime/vm/os_thread.cc:131: }
On 2016/01/04 23:07:55, siva wrote:
> Since everything inside the 'if statement' is commented out why not put the
> whole statement under #if 0....#endif

Done.

[zra, 2016-01-04 23:22:05]

Description was changed from

==========
Fixes for OSThread creation shutdown race.

Also, backs out bad change to the thread pool. The real fix is to
move the disable of OSThread creation until after the thread pool
shuts down.
==========

to

==========
Fixes for OSThread creation shutdown race.

Also, backs out bad change to the thread pool. The real fix is to
move the disable of OSThread creation until after the thread pool
shuts down.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/18929970a03d86cc6b97c3524809dc3cb095f1c8
==========

[zra, 2016-01-04 23:22:06]

Committed patchset #2 (id:20001) manually as
18929970a03d86cc6b97c3524809dc3cb095f1c8 (presubmit successful).