Fixes for OSThread creation shutdown race.

runtime/vm/thread_pool.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/thread_pool.h"
 
 #include "vm/flags.h"
 #include "vm/lockers.h"
 
 namespace dart {
@@ skipping 89 matching lines @@
     MonitorLocker eml(&exit_monitor_);
 
     // First tell all the workers to shut down.
     Worker* current = saved;
     OSThread* os_thread = OSThread::Current();
     ASSERT(os_thread != NULL);
     ThreadId id = os_thread->id();
     while (current != NULL) {
       Worker* next = current->all_next_;
       ThreadId currentId = current->id();
-      ASSERT(id != currentId);
-      if (currentId == OSThread::kInvalidThreadId) {
-        // If the thread id is invalid, it means the thread never started
-        // because OSThread creation was disabled. Destroy the Task and Worker.
-        delete current->task_;
-        delete current;
-      } else {
+      if (currentId != id) {
         AddWorkerToShutdownList(current);
-        current->Shutdown();
       }
+      current->Shutdown();
       current = next;
     }
     saved = NULL;
 
     // Wait until all workers will exit.
     while (shutting_down_workers_ != NULL) {
       // Here, we are waiting for workers to exit. When a worker exits we will
       // be notified.
       eml.Wait();
     }
@@ skipping 352 matching lines @@
     // is not due to a ThreadPool Shutdown. Thus, we simply delete the worker.
     // The worker's id is added to the thread pool's join list by
     // ReleaseIdleWorker, so in the case that the thread pool begins shutting
     // down immediately after returning from worker->Loop() above, we still
     // wait for the thread to exit by joining on it in Shutdown().
     delete worker;
   }
 }
 
 }  // namespace dart