Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1556993003: fix linear gradient assert, by explicitly clamping (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M src/effects/gradients/SkLinearGradient.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M tests/GradientTest.cpp View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
reed1
4 years, 11 months ago (2016-01-05 16:57:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556993003/20001
4 years, 11 months ago (2016-01-05 16:57:38 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 17:14:04 UTC) #7
caryclark
lgtm
4 years, 11 months ago (2016-01-05 17:40:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556993003/20001
4 years, 11 months ago (2016-01-05 18:01:04 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:01:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/aeab8ea4d7492dc996fa72de7298de81f8deed93

Powered by Google App Engine
This is Rietveld 408576698