Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1556853002: mac: Extend libtool filter to also match fat builds. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

mac: Extend libtool filter to also match fat builds. Now also matches lines such as path/to/libtool: for architecture: x86_64 file: foo.a(bar.o) has no symbols BUG=none R=scottmg@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/b362bbfbc877b4325b32c672148e815661ee8d1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pylib/gyp/mac_tool.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Nico
noticed this while doing some ios stuff; printed frequently there. see e.g. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/112120/steps/compile/logs/stdio
4 years, 11 months ago (2016-01-03 04:28:21 UTC) #2
scottmg
lgtm
4 years, 11 months ago (2016-01-04 18:53:49 UTC) #3
Nico
4 years, 11 months ago (2016-01-04 18:55:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b362bbfbc877b4325b32c672148e815661ee8d1c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698