pylib/gyp/mac_tool.py - Issue 1556853002: mac: Extend libtool filter to also match fat builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/mac_tool.py

Issue 1556853002: mac: Extend libtool filter to also match fat builds. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/mac_tool.py

diff --git a/pylib/gyp/mac_tool.py b/pylib/gyp/mac_tool.py

index eeeaceb0c7aa2388635855260b3d63edc58cd73a..82b5f0a70b0e9b00bfc7aab8369ecb469b010062 100755

--- a/pylib/gyp/mac_tool.py

+++ b/pylib/gyp/mac_tool.py

@@ -228,7 +228,8 @@ class MacTool(object):

def ExecFilterLibtool(self, *cmd_list):

"""Calls libtool and filters out '/path/to/libtool: file: foo.o has no

symbols'."""

- libtool_re = re.compile(r'^.*libtool: file: .* has no symbols$')

+ libtool_re = re.compile(r'^.*libtool: (?:for architecture: \S* )?'

+ r'file: .* has no symbols$')

libtool_re5 = re.compile(

r'^.*libtool: warning for library: ' +

r'.* the table of contents is empty ' +

« no previous file with comments | « no previous file | no next file » | no next file with comments »