Experiment with opening links opened via context menu in the foreground....

Experiment with opening links opened via context menu in the foreground.

BUG=none
TEST=tabs opened via "Open link in new tab..." should open in foreground, not background.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20927

[Miranda Callahan, 2009-07-17 01:59:15]

LGTM

On 2009/07/17 01:57:07, Ben Goodger wrote:
>

[Ben Goodger (Google), 2009-07-17 02:00:51]

To all those watching, I'll revert this after a few days unless we
decide it's the greatest thing ever.

-Ben

On Thu, Jul 16, 2009 at 6:59 PM, <mirandac@chromium.org> wrote:
> LGTM
>
> On 2009/07/17 01:57:07, Ben Goodger wrote:
>
>
>
>
> http://codereview.chromium.org/155671
>

[Anthony Ginepro, 2009-07-17 09:55:27]

On 2009/07/17 02:00:51, Ben Goodger wrote:
> To all those watching, I'll revert this after a few days unless we
> decide it's the greatest thing ever.
> 
> -Ben

Is there a way to vote against it or have fg/bg as an option ?
I like the way chrome opens my tabs in the bg while skimming through an article.

Thanks.

[cpascual, 2009-07-23 15:07:11]

I personally prefer this links to open in the background.  If I wanted them to
open in the foreground, I'd hold Ctrl and then press the link.  I go through
Google Reader and open all the articles I want to read first and then switch
tabs when I've finished.

Thanks.
On 2009/07/17 02:00:51, Ben Goodger wrote:
> To all those watching, I'll revert this after a few days unless we
> decide it's the greatest thing ever.
> 
> -Ben
> 
> On Thu, Jul 16, 2009 at 6:59 PM, <mirandac@chromium.org> wrote:
> > LGTM
> >
> > On 2009/07/17 01:57:07, Ben Goodger wrote:
> >
> >
> >
> >
> > http://codereview.chromium.org/155671
> >

[arthur.laycock, 2009-07-23 15:36:30]

I'll second preferring links opening in the background. Quite a few people have
expressed that they preferred the old style, open in background behaviour, on
the release blog
(http://googlechromereleases.blogspot.com/2009/07/dev-channel-update-301951.html).
At the very least give a choice for the style of opening new tabs. 


On 2009/07/23 15:07:11, cpascual wrote:
> I personally prefer this links to open in the background.  If I wanted them to
> open in the foreground, I'd hold Ctrl and then press the link.  I go through
> Google Reader and open all the articles I want to read first and then switch
> tabs when I've finished.
> 
> Thanks.
> On 2009/07/17 02:00:51, Ben Goodger wrote:
> > To all those watching, I'll revert this after a few days unless we
> > decide it's the greatest thing ever.
> > 
> > -Ben
> > 
> > On Thu, Jul 16, 2009 at 6:59 PM, <mirandac@chromium.org> wrote:
> > > LGTM
> > >
> > > On 2009/07/17 01:57:07, Ben Goodger wrote:
> > >
> > >
> > >
> > >
> > > http://codereview.chromium.org/155671
> > >

[Mehdi, 2009-07-23 17:26:41]

I think just having a choice is a good thing. Or else, if someone gets used to
opening tabs with the middle click, you have multiple options then.


On 2009/07/23 15:36:30, arthur.laycock wrote:
> I'll second preferring links opening in the background. Quite a few people
have
> expressed that they preferred the old style, open in background behaviour, on
> the release blog
>
(http://googlechromereleases.blogspot.com/2009/07/dev-channel-update-301951.html).
> At the very least give a choice for the style of opening new tabs. 
> 
> 
> On 2009/07/23 15:07:11, cpascual wrote:
> > I personally prefer this links to open in the background.  If I wanted them
to
> > open in the foreground, I'd hold Ctrl and then press the link.  I go through
> > Google Reader and open all the articles I want to read first and then switch
> > tabs when I've finished.
> > 
> > Thanks.
> > On 2009/07/17 02:00:51, Ben Goodger wrote:
> > > To all those watching, I'll revert this after a few days unless we
> > > decide it's the greatest thing ever.
> > > 
> > > -Ben
> > > 
> > > On Thu, Jul 16, 2009 at 6:59 PM, <mirandac@chromium.org> wrote:
> > > > LGTM
> > > >
> > > > On 2009/07/17 01:57:07, Ben Goodger wrote:
> > > >
> > > >
> > > >
> > > >
> > > > http://codereview.chromium.org/155671
> > > >

[bruce, 2009-07-29 03:18:35]

Oh please please change back. This new behaviour is straight IE!

[lordtyris, 2009-07-30 02:21:16]

It's been almost 2 weeks... has this been reverted yet? and when can we expect
the main Chrome branch to be reverted?
On 2009/07/17 02:00:51, Ben Goodger wrote:
> To all those watching, I'll revert this after a few days unless we
> decide it's the greatest thing ever.
> 
> -Ben
> 
> On Thu, Jul 16, 2009 at 6:59 PM, <mirandac@chromium.org> wrote:
> > LGTM
> >
> > On 2009/07/17 01:57:07, Ben Goodger wrote:
> >
> >
> >
> >
> > http://codereview.chromium.org/155671
> >

[JimR17, 2009-07-31 19:06:57]

Please tell me this is going back and soon! The default behavior should be the
existing behavior - unless there is a good reason to change - I'm all fore a
middle-click or ctrl-click to open in foreground option, but please put it back
:)

On 2009/07/30 02:21:16, lordtyris wrote:
> It's been almost 2 weeks... has this been reverted yet? and when can we expect
the main Chrome branch to be reverted?
> On 2009/07/17 02:00:51, Ben Goodger wrote:
> > To all those watching, I'll revert this after a few days unless we
> > decide it's the greatest thing ever.
> > 
> > -Ben

[Peter Kasting, 2009-07-31 19:55:46]

Please don't hijack review threads to ask questions and demand updates.

We already shipped a version of Chrome with this change reverted.

[JimR17, 2009-07-31 20:10:32]

On 2009/07/31 19:55:46, Peter Kasting wrote:
> Please don't hijack review threads to ask questions and demand updates.

The last two posts before mine make this same request.

Why the hostility?? 

I expressed my view that when introducing new features to a program they should
not change the default behaviour unless there is a good reason to do so.

Frankly, this is one of the things that Google is very good at - they tend to
keep things working as they've worked in the past, and add features that
supplement and add flexibility over time.

[Peter Kasting, 2009-07-31 20:13:56]

On 2009/07/31 20:10:32, JimR17 wrote:
> Why the hostility?? 

I'm not being hostile.  I'm letting you know that review threads are the wrong
place for asking followup questions about something weeks after it lands. 
Please email chromium-discuss@ instead.  That is a mailing list for these kind
of issues.