Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(73)

Issue 155671: Experiment with opening links opened via context menu in the foreground.... (Closed)

Created:
10 years, 7 months ago by Ben Goodger (Google)
Modified:
8 years, 8 months ago
CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Experiment with opening links opened via context menu in the foreground. BUG=none TEST=tabs opened via "Open link in new tab..." should open in foreground, not background. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Ben Goodger (Google)
10 years, 7 months ago (2009-07-17 01:57:07 UTC) #1
Miranda Callahan
LGTM On 2009/07/17 01:57:07, Ben Goodger wrote: >
10 years, 7 months ago (2009-07-17 01:59:15 UTC) #2
Ben Goodger (Google)
To all those watching, I'll revert this after a few days unless we decide it's ...
10 years, 7 months ago (2009-07-17 02:00:51 UTC) #3
Anthony Ginepro
On 2009/07/17 02:00:51, Ben Goodger wrote: > To all those watching, I'll revert this after ...
10 years, 7 months ago (2009-07-17 09:55:27 UTC) #4
cpascual
I personally prefer this links to open in the background. If I wanted them to ...
10 years, 7 months ago (2009-07-23 15:07:11 UTC) #5
arthur.laycock
I'll second preferring links opening in the background. Quite a few people have expressed that ...
10 years, 7 months ago (2009-07-23 15:36:30 UTC) #6
Mehdi
I think just having a choice is a good thing. Or else, if someone gets ...
10 years, 7 months ago (2009-07-23 17:26:41 UTC) #7
bruce
Oh please please change back. This new behaviour is straight IE!
10 years, 6 months ago (2009-07-29 03:18:35 UTC) #8
lordtyris
It's been almost 2 weeks... has this been reverted yet? and when can we expect ...
10 years, 6 months ago (2009-07-30 02:21:16 UTC) #9
JimR17
Please tell me this is going back and soon! The default behavior should be the ...
10 years, 6 months ago (2009-07-31 19:06:57 UTC) #10
Peter Kasting
Please don't hijack review threads to ask questions and demand updates. We already shipped a ...
10 years, 6 months ago (2009-07-31 19:55:46 UTC) #11
JimR17
On 2009/07/31 19:55:46, Peter Kasting wrote: > Please don't hijack review threads to ask questions ...
10 years, 6 months ago (2009-07-31 20:10:32 UTC) #12
Peter Kasting
10 years, 6 months ago (2009-07-31 20:13:56 UTC) #13
On 2009/07/31 20:10:32, JimR17 wrote:
> Why the hostility?? 

I'm not being hostile.  I'm letting you know that review threads are the wrong
place for asking followup questions about something weeks after it lands. 
Please email chromium-discuss@ instead.  That is a mailing list for these kind
of issues.

Powered by Google App Engine
This is Rietveld 408576698