Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1556493002: Remove now obsolete Shutdown method of ChromeBrowserStateManager. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
droger, jif
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@chrome_browser_provider
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now obsolete Shutdown method of ChromeBrowserStateManager. BUG=560854 Committed: https://crrev.com/df0e9c7e4aa855faa61ecd8d4bbaec46fcfa2de6 Cr-Commit-Position: refs/heads/master@{#367526}

Patch Set 1 #

Patch Set 2 : Rebase on https://codereview.chromium.org/1554683003 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M ios/chrome/browser/application_context_impl.cc View 1 chunk +1 line, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/browser_state/chrome_browser_state_manager.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
sdefresne
Please take a look. Please do *not* send to CQ.
4 years, 11 months ago (2015-12-29 14:35:11 UTC) #2
jif
lgtm, assuming the ShutDown() method is folded into the destructor.
4 years, 11 months ago (2015-12-29 14:41:05 UTC) #3
droger
lgtm
4 years, 11 months ago (2016-01-04 09:11:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556493002/20001
4 years, 11 months ago (2016-01-05 14:26:59 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 14:44:58 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 14:45:59 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df0e9c7e4aa855faa61ecd8d4bbaec46fcfa2de6
Cr-Commit-Position: refs/heads/master@{#367526}

Powered by Google App Engine
This is Rietveld 408576698