Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1554683003: Preparation for removal of ChromeBrowserStateManager::Shutdown. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
jif
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preparation for removal of ChromeBrowserStateManager::Shutdown. Provides a default implementation for the Shutdown method of ChromeBrowserStateManager so that the method can be removed once downstream no longer implements it (first patch of a three-way CL). BUG=560854 Committed: https://crrev.com/9a89a3205949b257e330e68618a0325e3bcb8a18 Cr-Commit-Position: refs/heads/master@{#367149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/public/provider/chrome/browser/browser_state/chrome_browser_state_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
sdefresne
Please take a look.
4 years, 11 months ago (2015-12-30 10:00:52 UTC) #3
sdefresne
Please send to CQ after taking the look :-)
4 years, 11 months ago (2015-12-30 10:01:10 UTC) #4
jif
lgtm
4 years, 11 months ago (2015-12-30 11:55:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554683003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554683003/1
4 years, 11 months ago (2015-12-30 11:55:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 11:59:40 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 12:00:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a89a3205949b257e330e68618a0325e3bcb8a18
Cr-Commit-Position: refs/heads/master@{#367149}

Powered by Google App Engine
This is Rietveld 408576698