Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issue 1556383002: Partially revert of Upstrem prefs changes (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Note: this is a partial revert. There were changes (such as incorrect ifdefs) that worth keeping. Original issue's description: > Upstrem prefs changes > > BUG=507792 > > Committed: https://crrev.com/1cffacd8f05734fae20c8816c3fc91abac5e38d4 > Cr-Commit-Position: refs/heads/master@{#363233} TBR=battre@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=507792 Committed: https://crrev.com/f78bbfd330ba31199cb4cdb7a52816b2bc492a6e Cr-Commit-Position: refs/heads/master@{#367593}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556383002/20001
4 years, 11 months ago (2016-01-05 18:41:59 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-05 18:44:10 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:44:54 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f78bbfd330ba31199cb4cdb7a52816b2bc492a6e
Cr-Commit-Position: refs/heads/master@{#367593}

Powered by Google App Engine
This is Rietveld 408576698