Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5644)

Unified Diff: chrome/browser/resources/net_internals/logviewpainter.js

Issue 1556018: Add support for attaching custom parameters to NetLog events. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/logviewpainter.js
===================================================================
--- chrome/browser/resources/net_internals/logviewpainter.js (revision 44049)
+++ chrome/browser/resources/net_internals/logviewpainter.js (working copy)
@@ -68,32 +68,29 @@
mainCell.style.paddingLeft = (INDENTATION_PX * entry.getDepth()) + "px";
- if (entry.orig.type == LogEntryType.TYPE_EVENT) {
- addTextNode(mainCell, getTextForEvent(entry));
+ addTextNode(mainCell, getTextForEvent(entry));
- // Get the elapsed time.
- if (entry.isBegin()) {
- addTextNode(dtLabelCell, '[dt=');
+ // Get the elapsed time.
+ if (entry.isBegin()) {
+ addTextNode(dtLabelCell, '[dt=');
- // Definite time.
- if (entry.end) {
- var dt = entry.end.orig.time - entry.orig.time;
- addTextNode(dtCell, dt + ']');
- } else {
- addTextNode(dtCell, '?]');
- }
+ // Definite time.
+ if (entry.end) {
+ var dt = entry.end.orig.time - entry.orig.time;
+ addTextNode(dtCell, dt + ']');
+ } else {
+ addTextNode(dtCell, '?]');
}
} else {
mainCell.colSpan = '3';
- if (entry.orig.type == LogEntryType.TYPE_STRING) {
- addTextNode(mainCell, entry.orig.string);
- } else if (entry.orig.type == LogEntryType.TYPE_ERROR_CODE) {
- // TODO(eroman): print symbolic name of error code.
- addTextNode(mainCell, "Network error: " + entry.orig.error_code);
- } else {
- addTextNode(mainCell, "Unrecognized entry type: " + entry.orig.type);
- }
}
+
+ // Output the extra parameters.
+ // TODO(eroman): Do type-specific formatting.
+ if (entry.orig.extra_parameters != undefined) {
+ addNode(mainCell, 'br');
+ addTextNode(mainCell, 'params: ' + entry.orig.extra_parameters);
+ }
}
}
@@ -108,7 +105,7 @@
text = '.';
}
- text += getKeyWithValue(LogEventType, entry.orig.event.type);
+ text += getKeyWithValue(LogEventType, entry.orig.type);
return text;
}
« no previous file with comments | « chrome/browser/resources/net_internals/loggrouper.js ('k') | chrome/browser/resources/net_internals/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698