Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Unified Diff: chrome/browser/resources/net_internals/loggrouper.js

Issue 1556018: Add support for attaching custom parameters to NetLog events. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/net_internals/loggrouper.js
===================================================================
--- chrome/browser/resources/net_internals/loggrouper.js (revision 44049)
+++ chrome/browser/resources/net_internals/loggrouper.js (working copy)
@@ -20,13 +20,11 @@
}
LogGroupEntry.prototype.isBegin = function() {
- return this.orig.type == LogEntryType.TYPE_EVENT &&
- this.orig.event.phase == LogEventPhase.PHASE_BEGIN;
+ return this.orig.phase == LogEventPhase.PHASE_BEGIN;
};
LogGroupEntry.prototype.isEnd = function() {
- return this.orig.type == LogEntryType.TYPE_EVENT &&
- this.orig.event.phase == LogEventPhase.PHASE_END
+ return this.orig.phase == LogEventPhase.PHASE_END
};
LogGroupEntry.prototype.getDepth = function() {
@@ -41,7 +39,7 @@
function findParentIndex(parentStack, eventType) {
for (var i = parentStack.length - 1; i >= 0; --i) {
- if (parentStack[i].orig.event.type == eventType)
+ if (parentStack[i].orig.type == eventType)
return i;
}
return -1;
@@ -67,7 +65,7 @@
if (groupEntry.isEnd()) {
// Walk up the parent stack to find the corresponding BEGIN for this END.
var parentIndex =
- findParentIndex(parentStack, groupEntry.orig.event.type);
+ findParentIndex(parentStack, groupEntry.orig.type);
if (parentIndex == -1) {
// Unmatched end.
« no previous file with comments | « chrome/browser/net/view_net_internals_job_factory.cc ('k') | chrome/browser/resources/net_internals/logviewpainter.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698