Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: net/base/net_log_event_type_list.h

Issue 1556018: Add support for attaching custom parameters to NetLog events. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address willchan's comments Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_log.cc ('k') | net/base/net_log_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log_event_type_list.h
===================================================================
--- net/base/net_log_event_type_list.h (revision 44049)
+++ net/base/net_log_event_type_list.h (working copy)
@@ -13,6 +13,11 @@
// log context around it.)
EVENT_TYPE(CANCELLED)
+// TODO(eroman): These are placeholders used by the deprecated
+// BoundNetLog::AddString() / BoundNetLog::AddStringLiteral().
+EVENT_TYPE(TODO_STRING)
+EVENT_TYPE(TODO_STRING_LITERAL)
+
// Marks the creation/destruction of a request (URLRequest or SocketStream).
// In the begin phase of this event, the message will contain a string which
// is the URL.
@@ -139,6 +144,13 @@
// Measures the time between URLRequest::Start() and
// URLRequest::ResponseStarted().
+//
+// For the BEGIN phase, the |extra_parameters| of the event will be of type
+// NetLogStringParameter, and will contain the URL.
+//
+// For the END phase, the |extra_parameters| of the event will be of type
+// NetLogIntegerParameter, and will contain the net error code. Altenately,
+// the extra_parameters may be NULL indicating no error code.
EVENT_TYPE(URL_REQUEST_START)
// ------------------------------------------------------------------------
@@ -227,6 +239,13 @@
// Measures the time between SocketStream::Connect() and
// SocketStream::DidEstablishConnection()
+//
+// For the BEGIN phase, the |extra_parameters| of the event will be of type
+// NetLogStringParameter, and will contain the URL.
+//
+// For the END phase, the |extra_parameters| of the event will be of type
+// NetLogIntegerParameter, and will contain the net error code. Altenately,
+// the extra_parameters may be NULL indicating no error code.
EVENT_TYPE(SOCKET_STREAM_CONNECT)
// A message sent on the SocketStream.
« no previous file with comments | « net/base/net_log.cc ('k') | net/base/net_log_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698