Add support for attaching custom parameters to NetLog events.

net/base/net_log_event_type_list.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE: No header guards are used, since this file is intended to be expanded
 // directly into net_log.h. DO NOT include this file anywhere else.
 
 // --------------------------------------------------------------------------
 // General pseudo-events
 // --------------------------------------------------------------------------
 
 // Something got cancelled (we determine what is cancelled based on the
 // log context around it.)
 EVENT_TYPE(CANCELLED)
 
+// TODO(eroman): These are placeholders used by the deprecated
+// BoundNetLog::AddString() / BoundNetLog::AddStringLiteral().
+EVENT_TYPE(TODO_STRING)
+EVENT_TYPE(TODO_STRING_LITERAL)
+
 // Marks the creation/destruction of a request (URLRequest or SocketStream).
 // In the begin phase of this event, the message will contain a string which
 // is the URL.
 EVENT_TYPE(REQUEST_ALIVE)
 
 // ------------------------------------------------------------------------
 // HostResolverImpl
 // ------------------------------------------------------------------------
 
 // The start/end of a host resolve (DNS) request.
@@ skipping 106 matching lines @@
 // Identifies the NetLog::Source() for the ConnectJob that this socket ended
 // up binding to.
 EVENT_TYPE(SOCKET_POOL_CONNECT_JOB_ID)
 
 // ------------------------------------------------------------------------
 // URLRequest
 // ------------------------------------------------------------------------
 
 // Measures the time between URLRequest::Start() and
 // URLRequest::ResponseStarted().
+//
+// For the BEGIN phase, the |extra_parameters| of the event will be of type
+// NetLogStringParameter, and will contain the URL.
+//
+// For the END phase, the |extra_parameters| of the event will be of type
+// NetLogIntegerParameter, and will contain the net error code. Altenately,
+// the extra_parameters may be NULL indicating no error code.
 EVENT_TYPE(URL_REQUEST_START)
 
 // ------------------------------------------------------------------------
 // HttpCache
 // ------------------------------------------------------------------------
 
 // Measures the time while opening a disk cache entry.
 EVENT_TYPE(HTTP_CACHE_OPEN_ENTRY)
 
 // Measures the time while creating a disk cache entry.
@@ skipping 68 matching lines @@
 
 // Measures the time to read HTTP response headers from the server.
 EVENT_TYPE(HTTP_STREAM_PARSER_READ_HEADERS)
 
 // ------------------------------------------------------------------------
 // SocketStream
 // ------------------------------------------------------------------------
 
 // Measures the time between SocketStream::Connect() and
 // SocketStream::DidEstablishConnection()
+//
+// For the BEGIN phase, the |extra_parameters| of the event will be of type
+// NetLogStringParameter, and will contain the URL.
+//
+// For the END phase, the |extra_parameters| of the event will be of type
+// NetLogIntegerParameter, and will contain the net error code. Altenately,
+// the extra_parameters may be NULL indicating no error code.
 EVENT_TYPE(SOCKET_STREAM_CONNECT)
 
 // A message sent on the SocketStream.
 EVENT_TYPE(SOCKET_STREAM_SENT)
 
 // A message received on the SocketStream.
 EVENT_TYPE(SOCKET_STREAM_RECEIVED)
 
 // ------------------------------------------------------------------------
 // SOCKS5ClientSocket
 // ------------------------------------------------------------------------
 
 // The time spent sending the "greeting" to the SOCKS server.
 EVENT_TYPE(SOCKS5_GREET_WRITE)
 
 // The time spent waiting for the "greeting" response from the SOCKS server.
 EVENT_TYPE(SOCKS5_GREET_READ)
 
 // The time spent sending the CONNECT request to the SOCKS server.
 EVENT_TYPE(SOCKS5_HANDSHAKE_WRITE)
 
 // The time spent waiting for the response to the CONNECT request.
 EVENT_TYPE(SOCKS5_HANDSHAKE_READ)