Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1556003003: remove shadeSpan16 from shader (Closed)

Created:
4 years, 11 months ago by reed2
Modified:
4 years, 11 months ago
Reviewers:
mtklein, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove shadeSpan16 from shader BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1556003003 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/4e5a758f3832594cf1828d367496b5a80bcab8ee

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : cleanup unused macro-generated procs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -654 lines) Patch
M include/core/SkShader.h View 4 chunks +2 lines, -46 lines 0 comments Download
M src/core/SkBitmapProcShader.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkBitmapProcShader.cpp View 3 chunks +3 lines, -76 lines 0 comments Download
M src/core/SkBitmapProcState.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 3 chunks +1 line, -35 lines 0 comments Download
M src/core/SkBitmapProcState_procs.h View 1 2 3 13 chunks +0 lines, -111 lines 0 comments Download
M src/core/SkBitmapProcState_sample.h View 1 2 3 7 chunks +10 lines, -30 lines 0 comments Download
M src/core/SkBitmapProcState_shaderproc.h View 1 2 3 3 chunks +2 lines, -6 lines 0 comments Download
M src/core/SkBlitter_RGB16.cpp View 4 chunks +1 line, -143 lines 0 comments Download
M src/core/SkColorShader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkFilterShader.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkShader.cpp View 5 chunks +0 lines, -23 lines 0 comments Download
M src/opts/SkBitmapProcState_arm_neon.cpp View 1 2 2 chunks +0 lines, -25 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_mips_dsp.cpp View 1 2 2 chunks +0 lines, -134 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 26 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556003003/1
4 years, 11 months ago (2016-01-05 03:05:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556003003/20001
4 years, 11 months ago (2016-01-05 03:12:18 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/3355) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on ...
4 years, 11 months ago (2016-01-05 03:13:34 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556003003/40001
4 years, 11 months ago (2016-01-05 03:38:41 UTC) #10
reed2
ptal
4 years, 11 months ago (2016-01-05 03:51:04 UTC) #12
mtklein
S32_D16_filter_DX_SSSE3 / S32_D16_filter_DXDY_SSSE3 in src/opts/SkBitmapProcState_opts_SSSE3.* can die too?
4 years, 11 months ago (2016-01-05 03:55:27 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 03:59:42 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556003003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556003003/60001
4 years, 11 months ago (2016-01-05 04:07:57 UTC) #18
mtklein
On 2016/01/05 03:55:27, mtklein wrote: > S32_D16_filter_DX_SSSE3 / S32_D16_filter_DXDY_SSSE3 in > src/opts/SkBitmapProcState_opts_SSSE3.* can die too? ...
4 years, 11 months ago (2016-01-05 04:21:03 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 04:27:32 UTC) #21
caryclark
lgtm
4 years, 11 months ago (2016-01-05 12:24:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556003003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556003003/60001
4 years, 11 months ago (2016-01-05 13:09:29 UTC) #24
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 13:10:36 UTC) #26
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4e5a758f3832594cf1828d367496b5a80bcab8ee

Powered by Google App Engine
This is Rietveld 408576698