Properly let the SSL engine know when the underlying stream is closed....

net/socket/ssl_client_socket_mac.cc

Index: net/socket/ssl_client_socket_mac.cc
===================================================================
--- net/socket/ssl_client_socket_mac.cc	(revision 20728)
+++ net/socket/ssl_client_socket_mac.cc	(working copy)
@@ -716,8 +716,10 @@
 
   if (rv < 0)
     return OSStatusFromNetError(rv);
-
-  return noErr;
+  else if (rv == 0) // stream closed

[John Grabowski, 2009/07/15 22:39:54]

Shouldn't this be (rv == OK) to be consistent with constant used in
NetErrorFromOSStatus() for conversion from errSSLClosedGraceful?

[Avi (use Gerrit), 2009/07/15 22:47:08]

The docs say "zero" is returned for end-of-stream (see socket.h) and for balance
(we're doing <0) I'm sticking to 0.

[wtc, 2009/07/16 00:22:50]

Yes, Read() returns a byte count or error code, so 0 is
approriate here.

+    return errSSLClosedGraceful;
+  else
+    return noErr;
 }
 
 // static