Properly let the SSL engine know when the underlying stream is closed....

net/socket/ssl_client_socket_mac.cc

 // Copyright (c) 2008-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/ssl_client_socket_mac.h"
 
 #include "base/singleton.h"
 #include "base/string_util.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
@@ skipping 698 matching lines @@
   }
 
   if (rv == ERR_IO_PENDING) {
     us->next_io_state_ = STATE_READ_COMPLETE;
   } else {
     us->read_io_buf_ = NULL;
   }
 
   if (rv < 0)
     return OSStatusFromNetError(rv);
-
-  return noErr;
+  else if (rv == 0) // stream closed

[John Grabowski, 2009/07/15 22:39:54]

Shouldn't this be (rv == OK) to be consistent with constant used in
NetErrorFromOSStatus() for conversion from errSSLClosedGraceful?

[Avi (use Gerrit), 2009/07/15 22:47:08]

The docs say "zero" is returned for end-of-stream (see socket.h) and for balance
(we're doing <0) I'm sticking to 0.

[wtc, 2009/07/16 00:22:50]

Yes, Read() returns a byte count or error code, so 0 is
approriate here.

+    return errSSLClosedGraceful;
+  else
+    return noErr;
 }
 
 // static
 OSStatus SSLClientSocketMac::SSLWriteCallback(SSLConnectionRef connection,
                                               const void* data,
                                               size_t* data_length) {
   SSLClientSocketMac* us =
       const_cast<SSLClientSocketMac*>(
           static_cast<const SSLClientSocketMac*>(connection));
 
@@ skipping 22 matching lines @@
 
   if (rv < 0 && rv != ERR_IO_PENDING) {
     return OSStatusFromNetError(rv);
   }
 
   // always lie to our caller
   return noErr;
 }
 
 }  // namespace net